Stream: git-wasmtime

Topic: wasmtime / PR #9092 Winch aarch64 memory load & store

Wasmtime GitHub notifications bot (Aug 08 2024 at 19:30):

vulc41n opened PR #9092 from vulc41n:winch-aarch64-memory to bytecodealliance:main:

Hey :wave:

This PR implements wasm_load, wasm_store and load_ptr instructions for winch targeting aarch64.

#8321

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Aug 08 2024 at 19:30):

vulc41n requested wasmtime-compiler-reviewers for a review on PR #9092.

Wasmtime GitHub notifications bot (Aug 08 2024 at 19:30):

vulc41n requested wasmtime-core-reviewers for a review on PR #9092.

Wasmtime GitHub notifications bot (Aug 08 2024 at 19:30):

vulc41n requested fitzgen for a review on PR #9092.

Wasmtime GitHub notifications bot (Aug 08 2024 at 19:32):

fitzgen requested saulecabrera for a review on PR #9092.

Wasmtime GitHub notifications bot (Aug 08 2024 at 19:32):

fitzgen commented on PR #9092:

Redirecting review to @saulecabrera

Wasmtime GitHub notifications bot (Aug 13 2024 at 11:51):

saulecabrera submitted PR review:

Looking good. Left one minor comment before landing this one.

Wasmtime GitHub notifications bot (Aug 13 2024 at 11:51):

saulecabrera submitted PR review:

Looking good. Left one minor comment before landing this one.

Wasmtime GitHub notifications bot (Aug 13 2024 at 11:51):

saulecabrera created PR review comment:

Could ldr instead of accepting a boolean accept Option<ExtKind>? Or instead -- and maybe this is what I'd prefer -- we could introduce two methods at the assembler level:

• sload
• uload

And we could dispatch from wasm_load to the corresponding method depending on the value of kind, this would make more explicit depending on the extension kind. Additionally this would make it less error prone than passing a boolean.

Wasmtime GitHub notifications bot (Aug 13 2024 at 12:26):

vulc41n updated PR #9092.

Wasmtime GitHub notifications bot (Aug 13 2024 at 13:32):

saulecabrera submitted PR review.

Wasmtime GitHub notifications bot (Aug 13 2024 at 13:47):

saulecabrera merged PR #9092.

Last updated: Dec 23 2024 at 12:05 UTC