Stream: git-wasmtime

Topic: wasmtime / PR #9083 cranelift-entity: `#[track_caller]` f...

Wasmtime GitHub notifications bot (Aug 07 2024 at 04:00):

ThePuzzlemaker requested cfallin for a review on PR #9083.

Wasmtime GitHub notifications bot (Aug 07 2024 at 04:00):

ThePuzzlemaker requested wasmtime-compiler-reviewers for a review on PR #9083.

Wasmtime GitHub notifications bot (Aug 07 2024 at 04:00):

ThePuzzlemaker opened PR #9083 from ThePuzzlemaker:entity-packedoption-track-caller to bytecodealliance:main:

This PR adds the #[track_caller] attribute to PackedOption::unwrap and PackedOption::expect. Using this attribute greatly improves the panic message of any .expect or .unwrap on a PackedOption by using the caller's location, not the location of packed_option.rs within cranelift-entity.

Wasmtime GitHub notifications bot (Aug 07 2024 at 04:44):

cfallin submitted PR review:

Seems reasonable; neat to learn about this attribute. Thanks!

Wasmtime GitHub notifications bot (Aug 07 2024 at 04:59):

cfallin merged PR #9083.

Last updated: Nov 22 2024 at 16:03 UTC