Wasmtime GitHub notifications bot (Aug 06 2024 at 16:45): Wasmtime GitHub notifications bot (Aug 06 2024 at 16:45):fitzgen opened PR #9082 from fitzgen:wasmtime-use-new-stack-maps to bytecodealliance:main:
This moves Wasmtime over from the old, regalloc-based stack maps system to the new "user" stack maps system.
Removing the old regalloc-based stack maps system is left for follow-up work.
All tests are passing, and I've been running the
table_opsfuzz target (which exercises GC refs, passing them between the host and Wasm, and their inline barriers) locally for a while with no more issues found (there was initially one issue found which was fixed in https://github.com/bytecodealliance/wasmtime/pull/9071).<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Aug 06 2024 at 16:45):fitzgen requested elliottt for a review on PR #9082.
Wasmtime GitHub notifications bot (Aug 06 2024 at 16:45):fitzgen requested wasmtime-fuzz-reviewers for a review on PR #9082.
Wasmtime GitHub notifications bot (Aug 06 2024 at 16:45):fitzgen requested wasmtime-core-reviewers for a review on PR #9082.
Wasmtime GitHub notifications bot (Aug 06 2024 at 16:45):fitzgen requested wasmtime-compiler-reviewers for a review on PR #9082.
Wasmtime GitHub notifications bot (Aug 06 2024 at 16:45):fitzgen requested wasmtime-default-reviewers for a review on PR #9082.
Wasmtime GitHub notifications bot (Aug 06 2024 at 17:00):fitzgen updated PR #9082.
Wasmtime GitHub notifications bot (Aug 06 2024 at 19:44):github-actions[bot] commented on PR #9082:
Subscribe to Label Action
cc @fitzgen
<details>
This issue or pull request has been labeled: "cranelift", "cranelift:area:machinst", "cranelift:wasm", "fuzzing", "wasmtime:api", "wasmtime:ref-types"Thus the following users have been cc'd because of the following labels:
- fitzgen: fuzzing, wasmtime:ref-types
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (Aug 16 2024 at 01:02):elliottt submitted PR review:
This looks great! It's so cool to see the refs turn into stack slot usage in the disas tests :)
Wasmtime GitHub notifications bot (Aug 16 2024 at 01:02):elliottt created PR review comment:
Why do all of these print
sp_to_sized_stack_slots: None? Do they not have any adjustment necessary to sp, or is this before the vcode has been finalized?
Wasmtime GitHub notifications bot (Aug 18 2024 at 23:17):fitzgen submitted PR review.
Wasmtime GitHub notifications bot (Aug 18 2024 at 23:17):fitzgen created PR review comment:
Ah, yep, this is because we print these before that member is finalized, which only happens after regalloc, during emission.
Wasmtime GitHub notifications bot (Aug 19 2024 at 00:33):fitzgen merged PR #9082.
Last updated: Dec 23 2024 at 13:07 UTC