Stream: git-wasmtime

Topic: wasmtime / PR #9075 pulley: sign-extend `xconst` immediates

view this post on Zulip Wasmtime GitHub notifications bot (Aug 06 2024 at 14:37):

Kmeakin edited PR #9075.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 06 2024 at 14:37):

Kmeakin edited PR #9075:

Change xconst8, xconst16, xconst32 and xconst64 instructions to sign-extend rather than zero-extend their immediates.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 06 2024 at 14:37):

Kmeakin commented on PR #9075:

Would you be up for switching the xconst* instructions to sign extending instead of zero extending? I think it probably doesn't makes sense to burn the opcode space on both sign- and zero-extending constant instructions, and sign extending is a little more flexible in general, so I think it would be better to only have sign-extending constant instructions.

Sure

view this post on Zulip Wasmtime GitHub notifications bot (Aug 06 2024 at 14:40):

Kmeakin updated PR #9075.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 06 2024 at 16:00):

fitzgen submitted PR review:

Perfect, thanks!

view this post on Zulip Wasmtime GitHub notifications bot (Aug 06 2024 at 16:15):

fitzgen merged PR #9075.

Last updated: Oct 23 2024 at 20:03 UTC