Stream: git-wasmtime

Topic: wasmtime / PR #9075 pulley: add `XSConst*` instructions

view this post on Zulip Wasmtime GitHub notifications bot (Aug 03 2024 at 22:16):

Kmeakin opened PR #9075 from Kmeakin:km/pulley-xsconst to bytecodealliance:main:

Added instructions for loading sign-extended immediates, since the readme said they were missing

view this post on Zulip Wasmtime GitHub notifications bot (Aug 03 2024 at 22:16):

Kmeakin requested fitzgen for a review on PR #9075.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 03 2024 at 22:16):

Kmeakin requested wasmtime-default-reviewers for a review on PR #9075.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 03 2024 at 22:24):

Kmeakin updated PR #9075.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 06 2024 at 00:24):

fitzgen submitted PR review:

Would you be up for switching the xconst* instructions to sign extending instead of zero extending? I think it probably doesn't makes sense to burn the opcode space on both sign- and zero-extending constant instructions, and sign extending is a little more flexible in general, so I think it would be better to only have sign-extending constant instructions.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 06 2024 at 13:44):

Kmeakin updated PR #9075.

Last updated: Nov 22 2024 at 17:03 UTC