Wasmtime GitHub notifications bot (Aug 03 2024 at 01:29): Wasmtime GitHub notifications bot (Aug 03 2024 at 01:29):iawia002 requested wasmtime-default-reviewers for a review on PR #9073.
Wasmtime GitHub notifications bot (Aug 03 2024 at 01:29):iawia002 requested pchickey for a review on PR #9073.
Wasmtime GitHub notifications bot (Aug 03 2024 at 01:29):iawia002 opened PR #9073 from iawia002:vet to bytecodealliance:main:
In the context of #9062, I removed a dependency but forgot to remove the corresponding configuration in the
supply-chain. However, the CI did not alert me about this. It is confusing to see a crate configuration in thesupply-chainthat we no longer depend on. Therefore, I added a step in the CI to check whether we need to execute the prune command.
Wasmtime GitHub notifications bot (Aug 04 2024 at 22:05):alexcrichton commented on PR #9073:
Thanks! I don't think we'll want to do this though because one workflow for adding vets needed for contributors is for maintainers to send a PR which contains the vet entries which are then used by a contributor's later PR. That means that vet entries might be added without anything in-tree using them but they're required for a soon-to-land PR. Another option is to push commits to contributors' PRs but that's not currently required at this time.
Wasmtime GitHub notifications bot (Aug 05 2024 at 01:06):iawia002 closed without merge PR #9073.
Last updated: Nov 22 2024 at 16:03 UTC