Stream: git-wasmtime

Topic: wasmtime / PR #9070 `cranelift-frontend`: Make `assert_eq...

Wasmtime GitHub notifications bot (Aug 02 2024 at 19:07):

fitzgen opened PR #9070 from fitzgen:make-assert-eq-output-usable-in-whole-crate to bytecodealliance:main:

This moves the macro to lib.rs so that it can be used in all the tests in the whole crate. It also makes it a little more usable by trimming whitespace and printing both the expected and actual values, in addition to the diff.

A follow-up commit will migrate various uses of assert_eq! over to it.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Aug 02 2024 at 19:07):

fitzgen requested cfallin for a review on PR #9070.

Wasmtime GitHub notifications bot (Aug 02 2024 at 19:07):

fitzgen requested wasmtime-compiler-reviewers for a review on PR #9070.

Wasmtime GitHub notifications bot (Aug 02 2024 at 19:10):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Aug 02 2024 at 19:10):

alexcrichton has enabled auto merge for PR #9070.

Wasmtime GitHub notifications bot (Aug 02 2024 at 19:31):

alexcrichton merged PR #9070.

Last updated: Nov 22 2024 at 16:03 UTC