Stream: git-wasmtime

Topic: wasmtime / PR #9065 Enforce `uninlined_format_args` for t...

Wasmtime GitHub notifications bot (Aug 02 2024 at 18:07):

hamirmahal requested elliottt for a review on PR #9065.

Wasmtime GitHub notifications bot (Aug 02 2024 at 18:07):

hamirmahal requested wasmtime-default-reviewers for a review on PR #9065.

Wasmtime GitHub notifications bot (Aug 02 2024 at 18:07):

hamirmahal opened PR #9065 from hamirmahal:clippy-uninlined-format-args to bytecodealliance:main:

closes #9064.

<!--

Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Aug 02 2024 at 18:32):

hamirmahal requested wasmtime-compiler-reviewers for a review on PR #9065.

Wasmtime GitHub notifications bot (Aug 02 2024 at 18:32):

hamirmahal updated PR #9065.

Wasmtime GitHub notifications bot (Aug 02 2024 at 19:09):

hamirmahal requested wasmtime-fuzz-reviewers for a review on PR #9065.

Wasmtime GitHub notifications bot (Aug 02 2024 at 19:09):

hamirmahal requested wasmtime-core-reviewers for a review on PR #9065.

Wasmtime GitHub notifications bot (Aug 02 2024 at 19:09):

hamirmahal updated PR #9065.

Wasmtime GitHub notifications bot (Aug 02 2024 at 19:55):

hamirmahal submitted PR review:

I can fix the /home/runner/work/wasmtime/wasmtime/target/debug/build/cranelift-codegen-d924ecd4c940ea8b/out/inst_builder.rs failures locally, but they're not in source control.

Wasmtime GitHub notifications bot (Aug 02 2024 at 20:50):

elliottt commented on PR #9065:

I can fix the /home/runner/work/wasmtime/wasmtime/target/debug/build/cranelift-codegen-d924ecd4c940ea8b/out/inst_builder.rs failures locally, but they're not in source control.

Those are generated during the build, so we should figure out a different approach for fixing the errors. Perhaps we can emit an allow annotation when generating them?

Wasmtime GitHub notifications bot (Aug 04 2024 at 22:02):

alexcrichton commented on PR #9065:

Similar #[allow] annotations look like this and there might be some other locations as well.

Wasmtime GitHub notifications bot (Aug 04 2024 at 22:36):

hamirmahal updated PR #9065.

Wasmtime GitHub notifications bot (Aug 04 2024 at 23:15):

hamirmahal updated PR #9065.

Wasmtime GitHub notifications bot (Aug 04 2024 at 23:27):

hamirmahal updated PR #9065.

Wasmtime GitHub notifications bot (Aug 05 2024 at 03:16):

hamirmahal updated PR #9065.

Wasmtime GitHub notifications bot (Aug 05 2024 at 03:30):

hamirmahal updated PR #9065.

Wasmtime GitHub notifications bot (Aug 05 2024 at 09:59):

alexcrichton submitted PR review:

Thank you again for your work on this!

Wasmtime GitHub notifications bot (Aug 05 2024 at 09:59):

alexcrichton submitted PR review:

Thank you again for your work on this!

Wasmtime GitHub notifications bot (Aug 05 2024 at 09:59):

alexcrichton created PR review comment:

Were these clones being removed part of a separate clippy lint that was firing? Perhaps another good candidate to enable at the workspace level? (find to do in a separate PR)

Wasmtime GitHub notifications bot (Aug 05 2024 at 10:15):

alexcrichton merged PR #9065.

Wasmtime GitHub notifications bot (Aug 05 2024 at 21:06):

hamirmahal commented on PR #9065:

You're welcome!

Wasmtime GitHub notifications bot (Aug 05 2024 at 21:06):

hamirmahal submitted PR review.

Wasmtime GitHub notifications bot (Aug 05 2024 at 21:06):

hamirmahal created PR review comment:

I believe so, yes. I might be able to get to that this weekend.

Wasmtime GitHub notifications bot (Aug 06 2024 at 22:22):

hamirmahal submitted PR review.

Wasmtime GitHub notifications bot (Aug 06 2024 at 22:22):

hamirmahal created PR review comment:

I took a look, and it seems like Cargo.toml already warns about clone_on_copy.

[workspace.lints.clippy]
# The default set of lints in Clippy is viewed as "too noisy" right now so
# they're all turned off by default. Selective lints are then enabled below as
# necessary.
all = { level = 'allow', priority = -1 }
clone_on_copy = 'warn'
map_clone = 'warn'
uninlined_format_args = 'warn'
unnecessary_to_owned = 'warn'
manual_strip = 'warn'

Last updated: Dec 23 2024 at 12:05 UTC