Wasmtime GitHub notifications bot (Aug 01 2024 at 17:47): Wasmtime GitHub notifications bot (Aug 01 2024 at 17:47):abrown opened PR #9056 from abrown:wasi-nn-track-upstream to bytecodealliance:main:
In #8873, we stopped tracking the wasi-nn's upstream WIT files temporarily because it was not clear to me at the time how to implement errors as CM resources. This PR fixes that, resuming tracking in the
vendor-wit.shand implementing what is needed in the wasi-nn crate.This leaves several threads unresolved, though:
- it looks like the
vendor-wit.shhas a new mechanism for retrieving files intowit/deps--at some point wasi-nn should migrate to use that (?)- it's not clear to me that "errors as resources" is even the best approach here; I've opened [#75] to consider the possibility of using "errors as records" instead.
- this PR identifies that the constructor for errors is in fact unnecessary, prompting an upstream change ([#76]) that should eventually be implemented here.
[#75]: https://github.com/WebAssembly/wasi-nn/pull/75
[#76]: https://github.com/WebAssembly/wasi-nn/pull/76prtest:full
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Aug 01 2024 at 17:47):abrown requested alexcrichton for a review on PR #9056.
Wasmtime GitHub notifications bot (Aug 01 2024 at 17:47):abrown requested wasmtime-core-reviewers for a review on PR #9056.
Wasmtime GitHub notifications bot (Aug 01 2024 at 17:47):abrown requested wasmtime-default-reviewers for a review on PR #9056.
Wasmtime GitHub notifications bot (Aug 01 2024 at 17:48):abrown edited PR #9056:
In #8873, we stopped tracking the wasi-nn's upstream WIT files temporarily because it was not clear to me at the time how to implement errors as CM resources. This PR fixes that, resuming tracking in the
vendor-wit.shand implementing what is needed in the wasi-nn crate.This leaves several threads unresolved, though:
- it looks like the
vendor-wit.shhas a new mechanism for retrieving files intowit/deps--at some point wasi-nn should migrate to use that (?)- it's not clear to me that "errors as resources" is even the best approach here; I've opened [#75] to consider the possibility of using "errors as records" instead.
- this PR identifies that the constructor for errors is in fact unnecessary, prompting an upstream change ([#76]) that should eventually be implemented here.
[#75]: https://github.com/WebAssembly/wasi-nn/pull/75
[#76]: https://github.com/WebAssembly/wasi-nn/pull/76<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Aug 01 2024 at 18:12):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Aug 01 2024 at 18:27):alexcrichton merged PR #9056.
Last updated: Oct 23 2024 at 20:03 UTC