hamirmahal requested alexcrichton for a review on PR #9047.
hamirmahal requested wasmtime-core-reviewers for a review on PR #9047.
hamirmahal opened PR #9047 from hamirmahal:style/simplify-string-formatting
to bytecodealliance:main
:
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->This change cleans up parts of the codebase for readability and maintainability.
hamirmahal requested wasmtime-default-reviewers for a review on PR #9047.
alexcrichton submitted PR review:
Thanks for this!
Out of curiosity how did you detect these cases? Is this perhaps a compiler lint or a clippy lint?
alexcrichton merged PR #9047.
hamirmahal commented on PR #9047:
You're welcome!
hamirmahal commented on PR #9047:
I use stricter
clippy
checks, likeclippy::pedantic
.
alexcrichton commented on PR #9047:
Oh nice! If you'd like feel free to add this lint here which would be a ratchet for the whole workspace. Probably not all of
pedantic
but this specific lint I think would be a reasonable candidate to add.
Last updated: Dec 23 2024 at 12:05 UTC