Stream: git-wasmtime

Topic: wasmtime / PR #9043 Bump tokio version to 1.30 to avoid d...

Wasmtime GitHub notifications bot (Jul 30 2024 at 02:29):

iawia002 opened PR #9043 from iawia002:deps to bytecodealliance:main:

In #8983, we introduced the redis dependency, which relies on socket2 0.5. This conflicts with our existing version 0.4, leading to cargo deny throwing the following error when trying to merge #9032 (https://github.com/bytecodealliance/wasmtime/actions/runs/10147488558/job/28058006599).

error[duplicate]: found 2 duplicate entries for crate 'socket2'
    ┌─ /home/runner/work/wasmtime/wasmtime/Cargo.lock:224:1
    │
224 │ ╭ socket2 0.4.9 registry+https://github.com/rust-lang/crates.io-index
225 │ │ socket2 0.5.7 registry+https://github.com/rust-lang/crates.io-index
    │ ╰───────────────────────────────────────────────────────────────────^ lock entries

Therefore, this patch updates the version of tokio from 1.29.1 to 1.30. With this update, we will no longer have duplicate socket2 dependencies, as both will depend on version 0.5.

NOTE: I could also downgrade the redis version to 0.25.0, which relies on socket2 0.4, but this version has significant bugs and has been yanked.

<img width="614" alt="Screenshot 2024-07-30 at 10 24 34" src="https://github.com/user-attachments/assets/fd8e82b9-3cb2-4a5b-a88a-6aa6bb8c1952">

Wasmtime GitHub notifications bot (Jul 30 2024 at 02:29):

iawia002 requested alexcrichton for a review on PR #9043.

Wasmtime GitHub notifications bot (Jul 30 2024 at 02:29):

iawia002 requested wasmtime-default-reviewers for a review on PR #9043.

Wasmtime GitHub notifications bot (Jul 30 2024 at 14:20):

alexcrichton updated PR #9043.

Wasmtime GitHub notifications bot (Jul 30 2024 at 14:20):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Jul 30 2024 at 14:20):

alexcrichton has enabled auto merge for PR #9043.

Wasmtime GitHub notifications bot (Jul 30 2024 at 14:51):

alexcrichton merged PR #9043.

Last updated: Nov 22 2024 at 17:03 UTC