Wasmtime GitHub notifications bot (Jul 29 2024 at 19:11): Wasmtime GitHub notifications bot (Jul 29 2024 at 19:11):Kmeakin requested wasmtime-compiler-reviewers for a review on PR #9040.
Wasmtime GitHub notifications bot (Jul 29 2024 at 19:11):Kmeakin opened PR #9040 from Kmeakin:km/loose-inequalities-to-strict-inequalities-v2 to bytecodealliance:main:
A 2nd attempt at https://github.com/bytecodealliance/wasmtime/pull/6130. This time with a regression test
Wasmtime GitHub notifications bot (Jul 29 2024 at 19:11):Kmeakin requested elliottt for a review on PR #9040.
Wasmtime GitHub notifications bot (Jul 29 2024 at 20:44):github-actions[bot] commented on PR #9040:
Subscribe to Label Action
cc @cfallin, @fitzgen
<details>
This issue or pull request has been labeled: "cranelift", "isle"Thus the following users have been cc'd because of the following labels:
- cfallin: isle
- fitzgen: isle
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (Jul 30 2024 at 09:46):Kmeakin requested wasmtime-core-reviewers for a review on PR #9040.
Wasmtime GitHub notifications bot (Jul 30 2024 at 09:46):Kmeakin updated PR #9040.
Wasmtime GitHub notifications bot (Aug 02 2024 at 21:05):elliottt submitted PR review.
Wasmtime GitHub notifications bot (Aug 02 2024 at 21:05):elliottt created PR review comment:
Is the main difference to #6130 this commented out rule?
Wasmtime GitHub notifications bot (Aug 03 2024 at 13:59):Kmeakin submitted PR review.
Wasmtime GitHub notifications bot (Aug 03 2024 at 13:59):Kmeakin created PR review comment:
Yes
Wasmtime GitHub notifications bot (Aug 05 2024 at 22:58):Kmeakin updated PR #9040.
Wasmtime GitHub notifications bot (Aug 05 2024 at 23:11):Kmeakin updated PR #9040.
Wasmtime GitHub notifications bot (Aug 05 2024 at 23:16):Kmeakin updated PR #9040.
Wasmtime GitHub notifications bot (Aug 05 2024 at 23:23):elliottt submitted PR review.
Wasmtime GitHub notifications bot (Aug 05 2024 at 23:23):elliottt created PR review comment:
Would you mind adding a comment explaining why this is currently commented out? With that added, I think this should be good to merge :+1:
Wasmtime GitHub notifications bot (Aug 06 2024 at 14:49):Kmeakin submitted PR review.
Wasmtime GitHub notifications bot (Aug 06 2024 at 14:49):Kmeakin created PR review comment:
I believe it has been fixed by https://github.com/bytecodealliance/wasmtime/commit/0683b84b40207d8ec0c9044ef418fbd1f23a62f9
Wasmtime GitHub notifications bot (Aug 06 2024 at 15:55):elliottt submitted PR review.
Wasmtime GitHub notifications bot (Aug 06 2024 at 15:55):elliottt created PR review comment:
Should it be un-commented now?
Wasmtime GitHub notifications bot (Aug 06 2024 at 16:10):Kmeakin submitted PR review.
Wasmtime GitHub notifications bot (Aug 06 2024 at 16:10):Kmeakin created PR review comment:
I was wrong. I thought it had been fixed, but that was just because I forgot to uncomment it
Last updated: Dec 23 2024 at 13:07 UTC