alexcrichton opened PR #9037 from alexcrichton:run-more-tests
to bytecodealliance:main
:
This commit updates
build-test-matrix.js
to calculate PR tests to never early-returnfalse
. The current structure for PR tests will iterate over most matrix entries and filter them out based on whether they're applicable or not given the commit message and modified files. The thinking is that an early-return offalse
might be a false-negative where a later filter enables the test. By only early-returningtrue
this enables any passing predicate to cause the tests to be run on a PR. Note that this has no effect on merge queues since those always and unconditionally run everything.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
alexcrichton requested pchickey for a review on PR #9037.
alexcrichton requested wasmtime-default-reviewers for a review on PR #9037.
pchickey submitted PR review.
alexcrichton merged PR #9037.
Last updated: Nov 22 2024 at 17:03 UTC