Stream: git-wasmtime

Topic: wasmtime / PR #9037 Change `build-test-matrix.js` to run ...


view this post on Zulip Wasmtime GitHub notifications bot (Jul 29 2024 at 15:47):

alexcrichton opened PR #9037 from alexcrichton:run-more-tests to bytecodealliance:main:

This commit updates build-test-matrix.js to calculate PR tests to never early-return false. The current structure for PR tests will iterate over most matrix entries and filter them out based on whether they're applicable or not given the commit message and modified files. The thinking is that an early-return of false might be a false-negative where a later filter enables the test. By only early-returning true this enables any passing predicate to cause the tests to be run on a PR. Note that this has no effect on merge queues since those always and unconditionally run everything.

<!--
Please make sure you include the following information:

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

view this post on Zulip Wasmtime GitHub notifications bot (Jul 29 2024 at 15:47):

alexcrichton requested pchickey for a review on PR #9037.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 29 2024 at 15:47):

alexcrichton requested wasmtime-default-reviewers for a review on PR #9037.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 29 2024 at 17:19):

pchickey submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 29 2024 at 17:36):

alexcrichton merged PR #9037.


Last updated: Nov 22 2024 at 17:03 UTC