alexcrichton opened PR #9036 from alexcrichton:fail-on-i686
to bytecodealliance:main
:
This commit adds a more first-class error in the build script for the
wasmtime
crate to indicate that 32-bit platforms are not supported. While there is acompile_error!
with somewhat similar information it is not too helpful because the compiler keeps compiling things after thecompile_error!
is reached meaning that the absence of asys
module cascades to many other compile errors as well. This presents a more readable error with links to github issues in a way that halts the build and should prevent unsupported crates from being built.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
alexcrichton requested fitzgen for a review on PR #9036.
alexcrichton requested wasmtime-core-reviewers for a review on PR #9036.
fitzgen submitted PR review:
:+1:
alexcrichton closed without merge PR #9036.
alexcrichton commented on PR #9036:
Given the error in CI I've decided on a different approach in https://github.com/bytecodealliance/wasmtime/pull/9039
Last updated: Dec 23 2024 at 12:05 UTC