Stream: git-wasmtime

Topic: wasmtime / PR #9030 Fix `fmin`/`fmax` cprop miscompilatio...

Wasmtime GitHub notifications bot (Jul 27 2024 at 18:34):

beetrees requested wasmtime-compiler-reviewers for a review on PR #9030.

Wasmtime GitHub notifications bot (Jul 27 2024 at 18:34):

beetrees requested fitzgen for a review on PR #9030.

Wasmtime GitHub notifications bot (Jul 27 2024 at 18:34):

beetrees opened PR #9030 from beetrees:fix-cprop-fmin-fmax to bytecodealliance:main:

Currently, constant propagation for f32/f64 fmin/fmax always outputs the first input when both inputs are zeros. However, the semantics of the fmin/fmax instructions require that -0.0 be treated as less than 0.0. This PR fixes this and adds tests to ensure it does not reoccur. Const prop support for f16/f128 fmin/fmax is also added.

f16/f128 issue: #8312

Wasmtime GitHub notifications bot (Jul 27 2024 at 18:36):

beetrees edited PR #9030:

Currently, constant propagation for f32/f64 fmin/fmax always outputs the first input when both inputs are zeros. However, the semantics of the fmin/fmax instructions require that -0.0 be treated as less than 0.0. This PR fixes this and adds test cases to ensure the issue does not reoccur. Const prop support for f16/f128 fmin/fmax is also added.

f16/f128 issue: #8312

Wasmtime GitHub notifications bot (Jul 27 2024 at 20:44):

github-actions[bot] commented on PR #9030:

Subscribe to Label Action

cc @cfallin, @fitzgen

<details>
This issue or pull request has been labeled: "cranelift", "isle"

Thus the following users have been cc'd because of the following labels:

• cfallin: isle
• fitzgen: isle

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (Jul 29 2024 at 16:12):

fitzgen submitted PR review:

Looks great, thanks!

Wasmtime GitHub notifications bot (Jul 29 2024 at 16:29):

fitzgen merged PR #9030.

Last updated: Oct 23 2024 at 20:03 UTC