Stream: git-wasmtime

Topic: wasmtime / PR #9016 Fix feature combinations in testing


view this post on Zulip Wasmtime GitHub notifications bot (Jul 26 2024 at 04:36):

iawia002 opened PR #9016 from iawia002:feature to bytecodealliance:main:

I reencountered the issue of feature combinations in this CI, similar to #8997:

error[E0277]: the trait bound `cranelift_codegen::ir::GlobalValue: Serialize` is not satisfied
    --> cranelift/wasm/src/heap.rs:67:12
     |
67   |     derive(serde_derive::Serialize, serde_derive::Deserialize)
     |            ^^^^^^^^^^^^^^^^^^^^^^^ the trait `Serialize` is not implemented for `cranelift_codegen::ir::GlobalValue`

cc @alexcrichton

view this post on Zulip Wasmtime GitHub notifications bot (Jul 26 2024 at 04:36):

iawia002 requested abrown for a review on PR #9016.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 26 2024 at 04:36):

iawia002 requested wasmtime-compiler-reviewers for a review on PR #9016.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 26 2024 at 14:34):

alexcrichton submitted PR review:

Thanks!

view this post on Zulip Wasmtime GitHub notifications bot (Jul 26 2024 at 15:05):

alexcrichton merged PR #9016.


Last updated: Dec 23 2024 at 12:05 UTC