Stream: git-wasmtime

Topic: wasmtime / PR #9011 Winch: Rename simd spec tests so they...

Wasmtime GitHub notifications bot (Jul 25 2024 at 14:50):

jeffcharles opened PR #9011 from jeffcharles:run-subset-of-simd-tests-in-winch to bytecodealliance:main:

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
I noticed the SIMD tests I added to the misc_testsuite under winch were not actually executing. I then realized the wast.rs file includes this check to mark Wast tests that start with simd as unsupported by Winch. This changes the SIMD tests I've added under Winch to start with _simd_ instead so those tests are recognized as supported and are executed as a result. I've also commented out a couple functions and tests in the misc_testsuite/winch directory which use SIMD instructions which Winch does not currently support.

Alternatively, I could make a larger change to the wast.rs file so the check for whether a given test in Winch is supported will label any test in misc_testsuite/winch as supported. The reason I'm leaning to not doing that now is I plan to remove all of the _simd_ tests from under misc_testsuite/winch and delete the parts.starts_with("simd") check when Winch fully supports SIMD so Winch will run the SIMD tests in spec testsuite. Having the copies of the spec tests starting with _simd_ will also conveniently make it easier to identify which tests to delete when full SIMD support is completed. But I am open to using that approach instead if it would be preferable.

Wasmtime GitHub notifications bot (Jul 25 2024 at 15:04):

jeffcharles has marked PR #9011 as ready for review.

Wasmtime GitHub notifications bot (Jul 25 2024 at 15:04):

jeffcharles requested fitzgen for a review on PR #9011.

Wasmtime GitHub notifications bot (Jul 25 2024 at 15:04):

jeffcharles requested wasmtime-core-reviewers for a review on PR #9011.

Wasmtime GitHub notifications bot (Jul 25 2024 at 15:50):

saulecabrera submitted PR review.

Wasmtime GitHub notifications bot (Jul 25 2024 at 16:05):

saulecabrera merged PR #9011.

Last updated: Nov 22 2024 at 17:03 UTC