Stream: git-wasmtime

Topic: wasmtime / PR #9005 Cranelift(x64): provide better panic ...

Wasmtime GitHub notifications bot (Jul 24 2024 at 18:09):

fitzgen opened PR #9005 from fitzgen:better-panic-messages-for-newtype-regs to bytecodealliance:main:

1. Add Gpr::unwrap_new and etc... constructors inside the macro that defines all the newtypes. These have better error messages on failure than Gpr::new(r).unwrap() would.

2. Use those new constructors everywhere we were otherwise doing Gpr::new(r).unwrap() and etc...

Note that (2) is purely mechanical, so whoever is assigned to review this can probably just focus on the changes inside the macro.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Jul 24 2024 at 18:09):

fitzgen requested elliottt for a review on PR #9005.

Wasmtime GitHub notifications bot (Jul 24 2024 at 18:09):

fitzgen requested wasmtime-compiler-reviewers for a review on PR #9005.

Wasmtime GitHub notifications bot (Jul 24 2024 at 18:12):

fitzgen updated PR #9005.

Wasmtime GitHub notifications bot (Jul 24 2024 at 18:21):

elliottt submitted PR review:

Much nicer messages!

Wasmtime GitHub notifications bot (Jul 24 2024 at 20:44):

github-actions[bot] commented on PR #9005:

Subscribe to Label Action

cc @cfallin, @fitzgen, @saulecabrera

<details>
This issue or pull request has been labeled: "cranelift", "cranelift:area:x64", "isle", "winch"

Thus the following users have been cc'd because of the following labels:

• cfallin: isle
• fitzgen: isle
• saulecabrera: winch

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (Jul 24 2024 at 23:10):

fitzgen updated PR #9005.

Wasmtime GitHub notifications bot (Jul 24 2024 at 23:10):

fitzgen has enabled auto merge for PR #9005.

Wasmtime GitHub notifications bot (Jul 24 2024 at 23:35):

fitzgen merged PR #9005.

Last updated: Nov 22 2024 at 17:03 UTC