Stream: git-wasmtime

Topic: wasmtime / PR #9000 Fix a safepoints bug involving block ...

view this post on Zulip Wasmtime GitHub notifications bot (Jul 23 2024 at 19:12):

fitzgen requested elliottt for a review on PR #9000.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 23 2024 at 19:12):

fitzgen requested wasmtime-compiler-reviewers for a review on PR #9000.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 23 2024 at 19:12):

fitzgen opened PR #9000 from fitzgen:fix-safepoints-bug-with-cursors-and-block-params to bytecodealliance:main:

We weren't setting the cursor position correctly after inserting spills for block parameters that need inclusion in stack maps, which caused us to accidentally skip over the first instruction in the block sometimes.

Also move some tests around and add logging for the rewriting phase of user stack maps (see each separate commit).

view this post on Zulip Wasmtime GitHub notifications bot (Jul 23 2024 at 19:12):

fitzgen commented on PR #9000:

heyyy #9000!!

view this post on Zulip Wasmtime GitHub notifications bot (Jul 23 2024 at 19:23):

elliottt submitted PR review:

Makes sense to me!

view this post on Zulip Wasmtime GitHub notifications bot (Jul 23 2024 at 19:41):

fitzgen merged PR #9000.

Last updated: Nov 22 2024 at 16:03 UTC