Stream: git-wasmtime

Topic: wasmtime / PR #8992 Run `cargo publish --dry-run` instead...

Wasmtime GitHub notifications bot (Jul 22 2024 at 19:44):

alexcrichton opened PR #8992 from alexcrichton:publish-dry-run to bytecodealliance:main:

This commit updates the ./scripts/publish.rs script used on CI to manage this workspace to run cargo publish --dry-run. That seems to have a few more checks than cargo package and would have caught one failure condition from #8987. The missing categories failure condition can't be caught by Cargo right now without actually publishing, so that'll have to be left for a future fix on a future day.

Closes #8987

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Jul 22 2024 at 19:44):

alexcrichton requested elliottt for a review on PR #8992.

Wasmtime GitHub notifications bot (Jul 22 2024 at 19:44):

alexcrichton requested wasmtime-default-reviewers for a review on PR #8992.

Wasmtime GitHub notifications bot (Jul 22 2024 at 19:50):

fitzgen submitted PR review:

Do we still need to rm ./.cargo/ and do all the vendoring and stuff after this change? I'm pretty sure I lost a .cargo/config.toml once because I was debugging the publish script...

Wasmtime GitHub notifications bot (Jul 22 2024 at 19:54):

alexcrichton commented on PR #8992:

All that should still be the same yeah, no difference from before. It wouldn't be too hard though to add some checks about warning of overwriting local changes to the script though.

Wasmtime GitHub notifications bot (Jul 22 2024 at 19:59):

alexcrichton updated PR #8992.

Wasmtime GitHub notifications bot (Jul 22 2024 at 19:59):

alexcrichton has enabled auto merge for PR #8992.

Wasmtime GitHub notifications bot (Jul 22 2024 at 20:22):

alexcrichton closed without merge PR #8992.

Wasmtime GitHub notifications bot (Jul 22 2024 at 20:22):

alexcrichton commented on PR #8992:

Alas this won't work with Cargo I think, so we'll just have to eat the errors here and be more vigilant of new crates in the future. (aka we will all promptly forget about this until it bites us again)

Last updated: Nov 22 2024 at 16:03 UTC