Stream: git-wasmtime

Topic: wasmtime / PR #8982 Refactor `Ieee{16,32,64,128}`

Wasmtime GitHub notifications bot (Jul 20 2024 at 17:28):

beetrees opened PR #8982 from beetrees:ieee-refactor to bytecodealliance:main:

Deduplicate the Ieee{16,32,64,128} implementations using a macro.

The only methods/trait impls removed are:

• The inherent neg() method on Ieee32 and Ieee64: This was redundant to the Neg trait implementation (whose method is also called neg). Anywhere that want to call x.neg() instead of -x can still do so by useing core::ops::Neg.
• impl From<u64> for Ieee64: This only existed for Ieee64, was redundant to Ieee64::with_bits, and was only used in one place in a test. Using either Ieee64::with_bits or the From<f64> for Ieee64 impl as required is much clearer about intent.

Wasmtime GitHub notifications bot (Jul 20 2024 at 17:28):

beetrees requested elliottt for a review on PR #8982.

Wasmtime GitHub notifications bot (Jul 20 2024 at 17:28):

beetrees requested wasmtime-compiler-reviewers for a review on PR #8982.

Wasmtime GitHub notifications bot (Jul 25 2024 at 22:55):

elliottt submitted PR review:

This is a nice refactoring, thanks!

Wasmtime GitHub notifications bot (Jul 25 2024 at 23:10):

elliottt merged PR #8982.

Last updated: Dec 23 2024 at 12:05 UTC