Wasmtime GitHub notifications bot (Jul 19 2024 at 16:28): Wasmtime GitHub notifications bot (Jul 19 2024 at 16:28):alexcrichton opened PR #8976 from alexcrichton:fix-adc-sbb to bytecodealliance:main:
This isn't reachable from Cranelift today but in some various testing this is one of the issues I encountered. This fixes apparent copy/paste bugs with the
AdcandSbbinstructions with immediate operands.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Jul 19 2024 at 16:28):alexcrichton requested fitzgen for a review on PR #8976.
Wasmtime GitHub notifications bot (Jul 19 2024 at 16:28):alexcrichton requested wasmtime-compiler-reviewers for a review on PR #8976.
Wasmtime GitHub notifications bot (Jul 19 2024 at 18:40):fitzgen submitted PR review:
Nice find!
Wasmtime GitHub notifications bot (Jul 19 2024 at 18:56):fitzgen merged PR #8976.
Last updated: Oct 23 2024 at 20:03 UTC