Stream: git-wasmtime

Topic: wasmtime / PR #8976 x64: Fix encoding of adc/sbb with imm...


view this post on Zulip Wasmtime GitHub notifications bot (Jul 19 2024 at 16:28):

alexcrichton opened PR #8976 from alexcrichton:fix-adc-sbb to bytecodealliance:main:

This isn't reachable from Cranelift today but in some various testing this is one of the issues I encountered. This fixes apparent copy/paste bugs with the Adc and Sbb instructions with immediate operands.

<!--
Please make sure you include the following information:

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

view this post on Zulip Wasmtime GitHub notifications bot (Jul 19 2024 at 16:28):

alexcrichton requested fitzgen for a review on PR #8976.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 19 2024 at 16:28):

alexcrichton requested wasmtime-compiler-reviewers for a review on PR #8976.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 19 2024 at 18:40):

fitzgen submitted PR review:

Nice find!

view this post on Zulip Wasmtime GitHub notifications bot (Jul 19 2024 at 18:56):

fitzgen merged PR #8976.


Last updated: Dec 23 2024 at 12:05 UTC