Stream: git-wasmtime

Topic: wasmtime / PR #8971 winch: Improve scratch register handling


view this post on Zulip Wasmtime GitHub notifications bot (Jul 18 2024 at 14:04):

saulecabrera requested wasmtime-compiler-reviewers for a review on PR #8971.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 18 2024 at 14:04):

saulecabrera opened PR #8971 from saulecabrera:improve-scratch-register-handling to bytecodealliance:main:

This commit doesn't introduce any new behavior. It's mostly a follow-up to https://github.com/bytecodealliance/wasmtime/pull/7977.

This commit tries to reduce the repetitive pattern used to obtain the scrtach register by introducing a macro similar to the existing vmctx! macro.

This commit also improves the macro definition by using fully qualified paths.

<!--
Please make sure you include the following information:

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

view this post on Zulip Wasmtime GitHub notifications bot (Jul 18 2024 at 14:04):

saulecabrera requested abrown for a review on PR #8971.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 18 2024 at 14:14):

saulecabrera updated PR #8971.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 18 2024 at 16:44):

github-actions[bot] commented on PR #8971:

Subscribe to Label Action

cc @saulecabrera

<details>
This issue or pull request has been labeled: "winch"

Thus the following users have been cc'd because of the following labels:

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

view this post on Zulip Wasmtime GitHub notifications bot (Jul 19 2024 at 21:45):

saulecabrera requested fitzgen for a review on PR #8971.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 22 2024 at 16:29):

fitzgen submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 22 2024 at 16:46):

fitzgen merged PR #8971.


Last updated: Jan 10 2026 at 02:36 UTC