fitzgen opened PR #8962 from fitzgen:clear-stack-map-data-in-frontend-context
to bytecodealliance:main
:
We were previously failing to clear
self.stack_map_vars
andself.stack_map_values
. Clearingself.dfs
is not strictly necessary, since callingself.dfs.iter()
internally clears its internal data before iteration begins, but its nice to tidy up anyways. Additionally, match on all the fields ofself
so that if we add more, we get compiler errors to remind us to clear the new fields as well.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
fitzgen requested wasmtime-compiler-reviewers for a review on PR #8962.
fitzgen requested elliottt for a review on PR #8962.
elliottt submitted PR review.
fitzgen merged PR #8962.
Last updated: Dec 23 2024 at 12:05 UTC