Stream: git-wasmtime

Topic: wasmtime / PR #8960 Update the docs for building the C API

Wasmtime GitHub notifications bot (Jul 15 2024 at 21:02):

fitzgen requested pchickey for a review on PR #8960.

Wasmtime GitHub notifications bot (Jul 15 2024 at 21:02):

fitzgen requested wasmtime-core-reviewers for a review on PR #8960.

Wasmtime GitHub notifications bot (Jul 15 2024 at 21:02):

fitzgen opened PR #8960 from fitzgen:c-api-building-docs to bytecodealliance:main:

Suggest cmake since that is what we test in CI and keep working.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Jul 15 2024 at 21:02):

fitzgen requested wasmtime-default-reviewers for a review on PR #8960.

Wasmtime GitHub notifications bot (Jul 15 2024 at 21:11):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Jul 15 2024 at 21:11):

alexcrichton created PR review comment:

Coul

Wasmtime GitHub notifications bot (Jul 15 2024 at 21:11):

alexcrichton deleted PR review comment.

Wasmtime GitHub notifications bot (Jul 15 2024 at 21:13):

alexcrichton submitted PR review:

Thanks for this! Mind rewording this though based on cmake --build target/c-api --target install? Basically the "install" target should be run to produce the final output structure of the include dir and the lib dir which will have all the relevant artifacts. That'll avoid the need to document the internals of the build directory and asking users to weave together everything themselves.

For documentation if the link isn't already here we should also link to https://docs.wasmtime.dev/c-api/ to avoid users needing to install/configure doxygen themselves locally.

Wasmtime GitHub notifications bot (Jul 15 2024 at 21:50):

fitzgen updated PR #8960.

Wasmtime GitHub notifications bot (Jul 15 2024 at 21:57):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Jul 15 2024 at 21:57):

alexcrichton has enabled auto merge for PR #8960.

Wasmtime GitHub notifications bot (Jul 15 2024 at 22:17):

alexcrichton merged PR #8960.

Last updated: Nov 22 2024 at 17:03 UTC