Stream: git-wasmtime

Topic: wasmtime / PR #8952 Fix `clippy::doc_lazy_continuation` l...


view this post on Zulip Wasmtime GitHub notifications bot (Jul 13 2024 at 10:40):

waywardmonkeys requested wasmtime-core-reviewers for a review on PR #8952.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 13 2024 at 10:40):

waywardmonkeys requested fitzgen for a review on PR #8952.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 13 2024 at 10:41):

waywardmonkeys opened PR #8952 from waywardmonkeys:fix-doc-lazy-continuation-lints to bytecodealliance:main:

These make it easier to read ordered and unordered lists by having more consistent indentation.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 15 2024 at 14:28):

alexcrichton submitted PR review:

Thanks!

view this post on Zulip Wasmtime GitHub notifications bot (Jul 15 2024 at 14:43):

alexcrichton merged PR #8952.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 15 2024 at 14:43):

alexcrichton commented on PR #8952:

Also, if you're interested, we default allow all clippy lints in this workspace because it's found to be too noisy by default. These warnings showed up due to a misconfiguration issue. If you'd like though selectively adding lints to that [workspace.lints.clippy] block is something that's reasonable to do on a one-off basis. For example adding this lint to that block sounds like a good idea, although I think it will need to wait a bit because this lint was added in Rust 1.80 and we're using 1.79 in CI.


Last updated: Oct 23 2024 at 20:03 UTC