Stream: git-wasmtime

Topic: wasmtime / PR #8949 wasmtime: Remove GET_WASM_TRAP indire...

Wasmtime GitHub notifications bot (Jul 12 2024 at 23:22):

jameysharp requested fitzgen for a review on PR #8949.

Wasmtime GitHub notifications bot (Jul 12 2024 at 23:22):

jameysharp requested wasmtime-core-reviewers for a review on PR #8949.

Wasmtime GitHub notifications bot (Jul 12 2024 at 23:22):

jameysharp opened PR #8949 from jameysharp:inline-get-wasm-trap to bytecodealliance:main:

In the past, the wasmtime-runtime crate couldn't directly call get_wasm_trap because the registry of loaded modules was in the wasmtime crate, so it called through a global function pointer registered with init_traps instead.

Since the two crates were merged in #8501, we no longer need this indirection.

While I'm here, I've also split the former get_wasm_trap function into two parts: lookup_code finds a loaded module that had been previously registered with register_code, and the lookup_trap_code step is now done by a helper on CodeMemory. This makes the module registry more broadly useful.

I also simplified the code lookup step in two ways:

• I removed a redundant check from the code lookup. BTreeMap::range will only return entries where end >= pc, so the end < pc condition is always false.
• I used checked_sub instead of writing both the comparison and subtraction explicitly.

Wasmtime GitHub notifications bot (Jul 12 2024 at 23:30):

jameysharp updated PR #8949.

Wasmtime GitHub notifications bot (Jul 15 2024 at 15:38):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Jul 15 2024 at 15:54):

alexcrichton merged PR #8949.

Last updated: Nov 22 2024 at 16:03 UTC