Stream: git-wasmtime

Topic: wasmtime / PR #8948 Remove `unchecked_*` methods on `Root...

Wasmtime GitHub notifications bot (Jul 12 2024 at 22:09):

fitzgen opened PR #8948 from fitzgen:tidy-up-unchecked-gc-ref-getters to bytecodealliance:main:

Because they take a shared borrow of the store and return a shared borrow of the VMGcRef with the same lifetime, and because performing a GC requires a mutable borrow of the store, there actually was no reason to differentiate between checked and unchecked methods or require AutoAssertNoGc arguments.

Fixes https://github.com/bytecodealliance/wasmtime/issues/8940

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Jul 12 2024 at 22:09):

fitzgen requested alexcrichton for a review on PR #8948.

Wasmtime GitHub notifications bot (Jul 12 2024 at 22:09):

fitzgen requested wasmtime-core-reviewers for a review on PR #8948.

Wasmtime GitHub notifications bot (Jul 12 2024 at 22:18):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Jul 12 2024 at 22:18):

alexcrichton has enabled auto merge for PR #8948.

Wasmtime GitHub notifications bot (Jul 12 2024 at 22:33):

alexcrichton merged PR #8948.

Last updated: Nov 22 2024 at 16:03 UTC