wasmtime / PR #8945 Resolve aliases before inserting valu... · git-wasmtime

Why does the alias resolving need to be done? cranelift-frontend can and does change aliases on the fly. It feels iffy to immediately resolve them inside cranelift-frontend as there is nothing preventing the alias that was resolved to be changed later.

Wasmtime GitHub notifications bot (Jul 12 2024 at 17:10):

fitzgen commented on PR #8945:

Why does the alias resolving need to be done?

Because otherwise we would need to have a reverse-aliases map from a value to all of the values that alias it. This is necessary because when we find a definition, we kill it from the live set, so at that point we only have the non-alias value.

It feels iffy to immediately resolve them inside cranelift-frontend as there is nothing preventing the alias that was resolved to be changed later.

Note that the safepoint spilling and its liveness analysis happens as part of finishing a FunctionBuilder, so we don't need to worry about anything changing under our feet here.

Wasmtime GitHub notifications bot (Jul 12 2024 at 17:24):

fitzgen merged PR #8945.

Last updated: Oct 23 2024 at 20:03 UTC