Stream: git-wasmtime

Topic: wasmtime / PR #8937 `cranelift-frontend`: Specify stack m...

view this post on Zulip Wasmtime GitHub notifications bot (Jul 11 2024 at 00:39):

fitzgen opened PR #8937 from fitzgen:variables-need-stack-maps-too to bytecodealliance:main:

This makes it so that all uses of the variable are automatically marked as needing stack maps, which is a big simplification and removal of potential footguns for users.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 11 2024 at 00:39):

fitzgen requested cfallin for a review on PR #8937.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 11 2024 at 00:39):

fitzgen requested wasmtime-compiler-reviewers for a review on PR #8937.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 11 2024 at 00:39):

fitzgen requested alexcrichton for a review on PR #8937.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 11 2024 at 00:39):

fitzgen requested wasmtime-core-reviewers for a review on PR #8937.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 11 2024 at 00:44):

fitzgen updated PR #8937.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 11 2024 at 06:23):

bjorn3 submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 11 2024 at 06:23):

bjorn3 created PR review comment:

Would it be possible to introduce a new method instead. Most users of cranelift-frontend will not use stackmaps and may not even know what they are and thus not know what they should pass.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 11 2024 at 06:23):

bjorn3 edited PR review comment.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 11 2024 at 16:39):

fitzgen updated PR #8937.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 11 2024 at 16:40):

fitzgen submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 11 2024 at 16:40):

fitzgen created PR review comment:

I actually went back and forth on this, but after switching to a different method to declare that a variable needs inclusion in stack maps, rather than a parameter to declare_var (see most recent commit) I actually like the different method better. Thanks for the nudge!

view this post on Zulip Wasmtime GitHub notifications bot (Jul 11 2024 at 16:51):

alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 11 2024 at 17:06):

alexcrichton merged PR #8937.

Last updated: Dec 23 2024 at 12:05 UTC