Wasmtime GitHub notifications bot (Jul 09 2024 at 21:07): Wasmtime GitHub notifications bot (Jul 09 2024 at 21:07):fitzgen opened PR #8925 from fitzgen:gc-types-tweaks to bytecodealliance:main:
Splitting this out from a larger PR so that it is easier to review and everything can land quicker.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Jul 09 2024 at 21:07):fitzgen requested alexcrichton for a review on PR #8925.
Wasmtime GitHub notifications bot (Jul 09 2024 at 21:07):fitzgen requested wasmtime-core-reviewers for a review on PR #8925.
Wasmtime GitHub notifications bot (Jul 09 2024 at 21:12):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Jul 09 2024 at 21:12):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Jul 09 2024 at 21:12):alexcrichton created PR review comment:
Could this return
&ValTypeby usingconst I32: ValType = ValType::I32;and&I32for the i8/i16 case?
Wasmtime GitHub notifications bot (Jul 09 2024 at 21:15):fitzgen updated PR #8925.
Wasmtime GitHub notifications bot (Jul 09 2024 at 21:15):fitzgen submitted PR review.
Wasmtime GitHub notifications bot (Jul 09 2024 at 21:15):fitzgen created PR review comment:
Good call
Wasmtime GitHub notifications bot (Jul 09 2024 at 21:15):fitzgen has enabled auto merge for PR #8925.
Wasmtime GitHub notifications bot (Jul 09 2024 at 21:39):fitzgen merged PR #8925.
Last updated: Nov 22 2024 at 17:03 UTC