Stream: git-wasmtime

Topic: wasmtime / PR #8925 A handful of little tweaks for GC types


view this post on Zulip Wasmtime GitHub notifications bot (Jul 09 2024 at 21:07):

fitzgen opened PR #8925 from fitzgen:gc-types-tweaks to bytecodealliance:main:

Splitting this out from a larger PR so that it is easier to review and everything can land quicker.

<!--
Please make sure you include the following information:

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

view this post on Zulip Wasmtime GitHub notifications bot (Jul 09 2024 at 21:07):

fitzgen requested alexcrichton for a review on PR #8925.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 09 2024 at 21:07):

fitzgen requested wasmtime-core-reviewers for a review on PR #8925.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 09 2024 at 21:12):

alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 09 2024 at 21:12):

alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 09 2024 at 21:12):

alexcrichton created PR review comment:

Could this return &ValType by using const I32: ValType = ValType::I32; and &I32 for the i8/i16 case?

view this post on Zulip Wasmtime GitHub notifications bot (Jul 09 2024 at 21:15):

fitzgen updated PR #8925.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 09 2024 at 21:15):

fitzgen submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 09 2024 at 21:15):

fitzgen created PR review comment:

Good call

view this post on Zulip Wasmtime GitHub notifications bot (Jul 09 2024 at 21:15):

fitzgen has enabled auto merge for PR #8925.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 09 2024 at 21:39):

fitzgen merged PR #8925.


Last updated: Dec 23 2024 at 12:05 UTC