Wasmtime GitHub notifications bot (Jul 09 2024 at 16:27): Wasmtime GitHub notifications bot (Jul 09 2024 at 16:27):alexcrichton opened PR #8923 from alexcrichton:update-serve-authority-and-scheme to bytecodealliance:main:
This commit is aimed at fixing an accidental regression from #8861 where the
wasmtime servesubcommand stopped reporting some instances of authority and scheme. After discussion in #8878 the new logic implemented is:
Creation of an incoming request now explicitly requires specifying a scheme which is out-of-band information about how the surrounding server received the request.
The authority is stored separately within a request and is inferred from the URI's authority or the
Hostheader if present. If neither are present then an error is returned.Closes #8878
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Jul 09 2024 at 16:27):alexcrichton requested fitzgen for a review on PR #8923.
Wasmtime GitHub notifications bot (Jul 09 2024 at 16:27):alexcrichton requested wasmtime-core-reviewers for a review on PR #8923.
Wasmtime GitHub notifications bot (Jul 09 2024 at 16:34):fitzgen submitted PR review.
Wasmtime GitHub notifications bot (Jul 09 2024 at 16:34):fitzgen has enabled auto merge for PR #8923.
Wasmtime GitHub notifications bot (Jul 09 2024 at 17:11):alexcrichton merged PR #8923.
Last updated: Dec 23 2024 at 12:05 UTC