wasmtime / PR #8917 Add custom-pages-sizes to CLI flags · git-wasmtime

We should maybe eventually have a for_each_config_option macro to define both the CLI flags and the Config methods or something...

I was looking at how the CLI flags and Config are defined and it seems like the grouping rules are very different between the two. For CLI, flags are grouped under struct names such as "Optimize", "Codegen", "Debug", etc, while in the Config, fields are grouped to different struct names, such as "Tunables". The lack of the 1-1 mapping makes it hard to define CLI flags from the Config sturct.

Perhaps, adding a macro like [cli(Optimize)] or others to Config fields helps to generate these fields in their corresponding CLI structs?

In addition, the methods in the Config are not a 1-1 map to the fields as well... It might be a headache to write the macro that generates the methods according fields.

Wasmtime GitHub notifications bot (Aug 19 2024 at 16:50):

fitzgen commented on PR #8917:

I think even something that defines the public API of Config and keeps that in sync with the CLI flags, but doesn't define the implementation of those Config methods, would be helpful. And that should be possible regardless if the implementation depends on tunables or wasm features or whatever.

Last updated: Nov 22 2024 at 17:03 UTC