Stream: git-wasmtime

Topic: wasmtime / PR #8906 Add more documentation to `ArgumentPu...

Wasmtime GitHub notifications bot (Jul 07 2024 at 00:19):

camelid requested wasmtime-compiler-reviewers for a review on PR #8906.

Wasmtime GitHub notifications bot (Jul 07 2024 at 00:19):

camelid requested fitzgen for a review on PR #8906.

Wasmtime GitHub notifications bot (Jul 07 2024 at 00:19):

camelid opened PR #8906 from camelid:structarg-docs to bytecodealliance:main:

I was a bit unclear on what exactly it was for. I thought the u32 field
could also use some documentation to clarify its meaning.

cc #8852
cc https://bytecodealliance.zulipchat.com/#narrow/stream/217117-cranelift/topic/docs.20for.20StructArgument.2FStructReturn

Wasmtime GitHub notifications bot (Jul 07 2024 at 00:20):

camelid commented on PR #8906:

Please of course let me know if I misunderstood the purpose of StructArgument, or if you have suggestions for more details to add.

Wasmtime GitHub notifications bot (Jul 07 2024 at 00:22):

camelid updated PR #8906.

Wasmtime GitHub notifications bot (Jul 08 2024 at 18:56):

fitzgen submitted PR review:

Thanks!

Wasmtime GitHub notifications bot (Jul 08 2024 at 21:15):

alexcrichton merged PR #8906.

Wasmtime GitHub notifications bot (Jul 08 2024 at 21:41):

camelid commented on PR #8906:

@alexcrichton btw not sure if it matters, but it looks like the old status checks that hanged are still running: https://github.com/bytecodealliance/wasmtime/actions/runs/9845337787/job/27180700806. Not sure if you want to cancel that.

Last updated: Oct 23 2024 at 20:03 UTC