Stream: git-wasmtime

Topic: wasmtime / PR #8903 Various cleanups to the ABI handling ...

view this post on Zulip Wasmtime GitHub notifications bot (Jul 05 2024 at 12:05):

bjorn3 opened PR #8903 from bjorn3:abi-cleanup-part1 to bytecodealliance:main:

These are the relatively trivial parts split out of https://github.com/bytecodealliance/wasmtime/pull/8875. Each commit is a separate improvement.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 05 2024 at 12:05):

bjorn3 requested wasmtime-compiler-reviewers for a review on PR #8903.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 05 2024 at 12:05):

bjorn3 requested cfallin for a review on PR #8903.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 05 2024 at 13:44):

github-actions[bot] commented on PR #8903:

Subscribe to Label Action

cc @cfallin, @fitzgen

<details>
This issue or pull request has been labeled: "cranelift", "cranelift:area:aarch64", "cranelift:area:machinst", "cranelift:area:x64", "isle"

Thus the following users have been cc'd because of the following labels:

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

view this post on Zulip Wasmtime GitHub notifications bot (Jul 05 2024 at 14:20):

bjorn3 commented on PR #8903:

https://github.com/bytecodealliance/wasmtime/pull/8903/commits/20850f8054c255a049f00a2f037d774695c7f449 is responsible for the crash. It can be reproduced using cargo test --test wast -- Cranelift/pooling/tests/misc_testsuite/custom-page-sizes/custom-page-sizes.wast.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 05 2024 at 15:06):

bjorn3 commented on PR #8903:

Never mind. It actually crashes on the main branch too.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 08 2024 at 17:48):

bjorn3 updated PR #8903.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 16 2024 at 15:50):

bjorn3 commented on PR #8903:

Gentle ping

view this post on Zulip Wasmtime GitHub notifications bot (Jul 16 2024 at 16:04):

cfallin submitted PR review:

This looks great, thanks! I like the functional style (returning result registers) for gen_retval, that simplified things greatly. One naming request below otherwise good to merge.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 16 2024 at 16:04):

cfallin submitted PR review:

This looks great, thanks! I like the functional style (returning result registers) for gen_retval, that simplified things greatly. One naming request below otherwise good to merge.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 16 2024 at 16:04):

cfallin created PR review comment:

Can we call this ret rather than arg for consistency (with rets)?

view this post on Zulip Wasmtime GitHub notifications bot (Jul 16 2024 at 16:11):

bjorn3 updated PR #8903.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 16 2024 at 16:11):

bjorn3 submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 16 2024 at 16:11):

bjorn3 created PR review comment:

Done

view this post on Zulip Wasmtime GitHub notifications bot (Jul 16 2024 at 16:14):

cfallin has enabled auto merge for PR #8903.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 16 2024 at 16:38):

cfallin merged PR #8903.

Last updated: Nov 22 2024 at 17:03 UTC