bjorn3 opened PR #8903 from bjorn3:abi-cleanup-part1
to bytecodealliance:main
:
These are the relatively trivial parts split out of https://github.com/bytecodealliance/wasmtime/pull/8875. Each commit is a separate improvement.
bjorn3 requested wasmtime-compiler-reviewers for a review on PR #8903.
bjorn3 requested cfallin for a review on PR #8903.
github-actions[bot] commented on PR #8903:
Subscribe to Label Action
cc @cfallin, @fitzgen
<details>
This issue or pull request has been labeled: "cranelift", "cranelift:area:aarch64", "cranelift:area:machinst", "cranelift:area:x64", "isle"Thus the following users have been cc'd because of the following labels:
- cfallin: isle
- fitzgen: isle
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
https://github.com/bytecodealliance/wasmtime/pull/8903/commits/20850f8054c255a049f00a2f037d774695c7f449 is responsible for the crash. It can be reproduced using
cargo test --test wast -- Cranelift/pooling/tests/misc_testsuite/custom-page-sizes/custom-page-sizes.wast
.
Never mind. It actually crashes on the main branch too.
bjorn3 updated PR #8903.
Gentle ping
cfallin submitted PR review:
This looks great, thanks! I like the functional style (returning result registers) for
gen_retval
, that simplified things greatly. One naming request below otherwise good to merge.
cfallin submitted PR review:
This looks great, thanks! I like the functional style (returning result registers) for
gen_retval
, that simplified things greatly. One naming request below otherwise good to merge.
cfallin created PR review comment:
Can we call this
ret
rather thanarg
for consistency (withrets
)?
bjorn3 updated PR #8903.
bjorn3 submitted PR review.
bjorn3 created PR review comment:
Done
cfallin has enabled auto merge for PR #8903.
cfallin merged PR #8903.
Last updated: Dec 23 2024 at 12:05 UTC