Stream: git-wasmtime

Topic: wasmtime / PR #8900 `wasi-common`: remove `wasmtime` depe...

Wasmtime GitHub notifications bot (Jul 04 2024 at 10:06):

Robbepop opened PR #8900 from Robbepop:rf-wasi-common-sync-rm-wasmtime-dep to bytecodealliance:main:

Closes https://github.com/bytecodealliance/wasmtime/issues/8894.

The only optional usage of the wasmtime crate that I could find within the wasi-common/sync module is the following:

#[cfg(feature = "wasmtime")]
super::define_wasi!(block_on);

Which defines the add_to_linker methods for Wasmtime which is entirely optional.
Non Wasmtime users of wasi-common might want to define their own add_to_linker functions.

Locally I did not see any compile errors with the removal of this dependency of this PR.

Wasmtime GitHub notifications bot (Jul 04 2024 at 10:06):

Robbepop requested fitzgen for a review on PR #8900.

Wasmtime GitHub notifications bot (Jul 04 2024 at 10:06):

Robbepop requested wasmtime-core-reviewers for a review on PR #8900.

Wasmtime GitHub notifications bot (Jul 04 2024 at 10:08):

Robbepop edited PR #8900:

Closes https://github.com/bytecodealliance/wasmtime/issues/8894.

The only optional usage of the wasmtime crate that I could find within the wasi-common/sync module is the following:

#[cfg(feature = "wasmtime")]
super::define_wasi!(block_on);

Link: https://github.com/bytecodealliance/wasmtime/blob/main/crates/wasi-common/src/sync/mod.rs

Which defines the add_to_linker methods for Wasmtime which is entirely optional.
Non Wasmtime users of wasi-common might want to define their own add_to_linker functions.

Locally I did not see any compile errors with the removal of this dependency of this PR.

Wasmtime GitHub notifications bot (Jul 04 2024 at 10:08):

Robbepop edited PR #8900:

Closes https://github.com/bytecodealliance/wasmtime/issues/8894.

Motivation: This allows usage of wasi-common in non-Wasmtime Wasm runtimes.

The only optional usage of the wasmtime crate that I could find within the wasi-common/sync module is the following:

#[cfg(feature = "wasmtime")]
super::define_wasi!(block_on);

Link: https://github.com/bytecodealliance/wasmtime/blob/main/crates/wasi-common/src/sync/mod.rs

Which defines the add_to_linker methods for Wasmtime which is entirely optional.
Non Wasmtime users of wasi-common might want to define their own add_to_linker functions.

Locally I did not see any compile errors with the removal of this dependency of this PR.

Wasmtime GitHub notifications bot (Jul 04 2024 at 10:14):

Robbepop edited PR #8900:

Closes https://github.com/bytecodealliance/wasmtime/issues/8894.

Motivation: This allows usage of wasi-common in non-Wasmtime Wasm runtimes.

This was probably an oversight in https://github.com/bytecodealliance/wasmtime/pull/7881.

The only optional usage of the wasmtime crate that I could find within the wasi-common/sync module is the following:

#[cfg(feature = "wasmtime")]
super::define_wasi!(block_on);

Link: https://github.com/bytecodealliance/wasmtime/blob/main/crates/wasi-common/src/sync/mod.rs

Which defines the add_to_linker methods for Wasmtime which is entirely optional.
Non Wasmtime users of wasi-common might want to define their own add_to_linker functions.

Locally I did not see any compile errors with the removal of this dependency of this PR.

Wasmtime GitHub notifications bot (Jul 08 2024 at 13:41):

alexcrichton submitted PR review:

Thanks!

Wasmtime GitHub notifications bot (Jul 08 2024 at 13:56):

alexcrichton merged PR #8900.

Last updated: Oct 23 2024 at 20:03 UTC