Robbepop opened PR #8900 from Robbepop:rf-wasi-common-sync-rm-wasmtime-dep
to bytecodealliance:main
:
Closes https://github.com/bytecodealliance/wasmtime/issues/8894.
The only optional usage of the
wasmtime
crate that I could find within thewasi-common/sync
module is the following:#[cfg(feature = "wasmtime")] super::define_wasi!(block_on);
Which defines the
add_to_linker
methods for Wasmtime which is entirely optional.
Non Wasmtime users ofwasi-common
might want to define their ownadd_to_linker
functions.Locally I did not see any compile errors with the removal of this dependency of this PR.
Robbepop requested fitzgen for a review on PR #8900.
Robbepop requested wasmtime-core-reviewers for a review on PR #8900.
Robbepop edited PR #8900:
Closes https://github.com/bytecodealliance/wasmtime/issues/8894.
The only optional usage of the
wasmtime
crate that I could find within thewasi-common/sync
module is the following:#[cfg(feature = "wasmtime")] super::define_wasi!(block_on);
Link: https://github.com/bytecodealliance/wasmtime/blob/main/crates/wasi-common/src/sync/mod.rs
Which defines the
add_to_linker
methods for Wasmtime which is entirely optional.
Non Wasmtime users ofwasi-common
might want to define their ownadd_to_linker
functions.Locally I did not see any compile errors with the removal of this dependency of this PR.
Robbepop edited PR #8900:
Closes https://github.com/bytecodealliance/wasmtime/issues/8894.
Motivation: This allows usage of
wasi-common
in non-Wasmtime Wasm runtimes.The only optional usage of the
wasmtime
crate that I could find within thewasi-common/sync
module is the following:#[cfg(feature = "wasmtime")] super::define_wasi!(block_on);
Link: https://github.com/bytecodealliance/wasmtime/blob/main/crates/wasi-common/src/sync/mod.rs
Which defines the
add_to_linker
methods for Wasmtime which is entirely optional.
Non Wasmtime users ofwasi-common
might want to define their ownadd_to_linker
functions.Locally I did not see any compile errors with the removal of this dependency of this PR.
Robbepop edited PR #8900:
Closes https://github.com/bytecodealliance/wasmtime/issues/8894.
Motivation: This allows usage of
wasi-common
in non-Wasmtime Wasm runtimes.This was probably an oversight in https://github.com/bytecodealliance/wasmtime/pull/7881.
The only optional usage of the
wasmtime
crate that I could find within thewasi-common/sync
module is the following:#[cfg(feature = "wasmtime")] super::define_wasi!(block_on);
Link: https://github.com/bytecodealliance/wasmtime/blob/main/crates/wasi-common/src/sync/mod.rs
Which defines the
add_to_linker
methods for Wasmtime which is entirely optional.
Non Wasmtime users ofwasi-common
might want to define their ownadd_to_linker
functions.Locally I did not see any compile errors with the removal of this dependency of this PR.
alexcrichton submitted PR review:
Thanks!
alexcrichton merged PR #8900.
Last updated: Nov 22 2024 at 17:03 UTC