Stream: git-wasmtime

Topic: wasmtime / PR #8899 Wasmtime: Pop GC LIFO roots even when...


view this post on Zulip Wasmtime GitHub notifications bot (Jul 03 2024 at 19:46):

fitzgen opened PR #8899 from fitzgen:leaking-rooted-i31refs to bytecodealliance:main:

We can create and root i31refs without ever allocating a GC heap for the store, so we can't guard popping LIFO roots on the presence of a GC heap or else we risk unbounded growth of the LIFO root set.

<!--
Please make sure you include the following information:

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

view this post on Zulip Wasmtime GitHub notifications bot (Jul 03 2024 at 19:46):

fitzgen requested elliottt for a review on PR #8899.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 03 2024 at 19:46):

fitzgen requested wasmtime-core-reviewers for a review on PR #8899.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 03 2024 at 19:51):

fitzgen updated PR #8899.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 03 2024 at 21:44):

github-actions[bot] commented on PR #8899:

Subscribe to Label Action

cc @fitzgen

<details>
This issue or pull request has been labeled: "wasmtime:api", "wasmtime:ref-types"

Thus the following users have been cc'd because of the following labels:

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

view this post on Zulip Wasmtime GitHub notifications bot (Jul 08 2024 at 13:49):

alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 08 2024 at 14:04):

alexcrichton merged PR #8899.


Last updated: Dec 23 2024 at 12:05 UTC