Stream: git-wasmtime

Topic: wasmtime / PR #8893 cranelift: Add `f16const` and `f128co...


view this post on Zulip Wasmtime GitHub notifications bot (Jul 02 2024 at 00:12):

beetrees opened PR #8893 from beetrees:f16-f128-const to bytecodealliance:main:

This PR adds f16const and f128const instructions, as well as basic neg/abs/copysign constant propagation. The f128const instruction uses a Constant (like vconst) instead of directly storing the value in the instruction as InstructionData has a size of only 16 bytes.

Issue: #8312

view this post on Zulip Wasmtime GitHub notifications bot (Jul 02 2024 at 00:12):

beetrees requested wasmtime-compiler-reviewers for a review on PR #8893.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 02 2024 at 00:12):

beetrees requested elliottt for a review on PR #8893.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 02 2024 at 00:20):

beetrees updated PR #8893.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 02 2024 at 02:03):

github-actions[bot] commented on PR #8893:

Subscribe to Label Action

cc @cfallin, @fitzgen

<details>
This issue or pull request has been labeled: "cranelift", "cranelift:area:machinst", "cranelift:meta", "isle"

Thus the following users have been cc'd because of the following labels:

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

view this post on Zulip Wasmtime GitHub notifications bot (Jul 04 2024 at 10:22):

afonso360 submitted PR review:

I don't know if @elliottt wants to take a look as well, but this all looks correct to me!

view this post on Zulip Wasmtime GitHub notifications bot (Jul 04 2024 at 15:31):

beetrees updated PR #8893.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 04 2024 at 15:31):

beetrees commented on PR #8893:

I've just made a minor improvement to make the f128 cprop tests more readable.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 17 2024 at 16:27):

elliottt submitted PR review:

Sorry for the delay, this looks good to me!

view this post on Zulip Wasmtime GitHub notifications bot (Jul 17 2024 at 16:54):

elliottt merged PR #8893.


Last updated: Dec 23 2024 at 12:05 UTC