beetrees opened PR #8893 from beetrees:f16-f128-const
to bytecodealliance:main
:
This PR adds
f16const
andf128const
instructions, as well as basic neg/abs/copysign constant propagation. Thef128const
instruction uses aConstant
(likevconst
) instead of directly storing the value in the instruction asInstructionData
has a size of only 16 bytes.Issue: #8312
beetrees requested wasmtime-compiler-reviewers for a review on PR #8893.
beetrees requested elliottt for a review on PR #8893.
beetrees updated PR #8893.
github-actions[bot] commented on PR #8893:
Subscribe to Label Action
cc @cfallin, @fitzgen
<details>
This issue or pull request has been labeled: "cranelift", "cranelift:area:machinst", "cranelift:meta", "isle"Thus the following users have been cc'd because of the following labels:
- cfallin: isle
- fitzgen: isle
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
afonso360 submitted PR review:
I don't know if @elliottt wants to take a look as well, but this all looks correct to me!
beetrees updated PR #8893.
beetrees commented on PR #8893:
I've just made a minor improvement to make the f128 cprop tests more readable.
elliottt submitted PR review:
Sorry for the delay, this looks good to me!
elliottt merged PR #8893.
Last updated: Nov 22 2024 at 16:03 UTC