Stream: git-wasmtime

Topic: wasmtime / PR #8882 Update the wasm-tools family of crates

Wasmtime GitHub notifications bot (Jun 27 2024 at 21:45):

alexcrichton opened PR #8882 from alexcrichton:update-wasm-tools to bytecodealliance:main:

This notably brings in a limitation where component model flags types must have 32 or fewer flags in accordance with the transition plan of https://github.com/WebAssembly/component-model/issues/370. A feature flag is added to go back to the previous behavior to avoid breaking anyone too much.

This additionally brings in a fix for a panic when validating invalid modules with tail calls.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Jun 27 2024 at 21:45):

alexcrichton commented on PR #8882:

I'll note that this is a draft as I'd like to get in https://github.com/bytecodealliance/wit-bindgen/pull/990 and https://github.com/bytecodealliance/wit-bindgen/pull/989 and update wit-bindgen here too

Wasmtime GitHub notifications bot (Jun 27 2024 at 22:02):

alexcrichton updated PR #8882.

Wasmtime GitHub notifications bot (Jun 28 2024 at 00:15):

alexcrichton updated PR #8882.

Wasmtime GitHub notifications bot (Jun 28 2024 at 00:15):

alexcrichton has marked PR #8882 as ready for review.

Wasmtime GitHub notifications bot (Jun 28 2024 at 00:15):

alexcrichton requested wasmtime-core-reviewers for a review on PR #8882.

Wasmtime GitHub notifications bot (Jun 28 2024 at 00:15):

alexcrichton requested pchickey for a review on PR #8882.

Wasmtime GitHub notifications bot (Jun 28 2024 at 00:15):

alexcrichton requested wasmtime-default-reviewers for a review on PR #8882.

Wasmtime GitHub notifications bot (Jun 28 2024 at 00:15):

alexcrichton commented on PR #8882:

Ok should be reading pending CI

Wasmtime GitHub notifications bot (Jun 28 2024 at 00:36):

alexcrichton updated PR #8882.

Wasmtime GitHub notifications bot (Jun 28 2024 at 00:36):

alexcrichton commented on PR #8882:

On second thought let's not update wit-bindgen.

Wasmtime GitHub notifications bot (Jun 28 2024 at 02:48):

github-actions[bot] commented on PR #8882:

Label Messager: wasmtime:config

It looks like you are changing Wasmtime's configuration options. Make sure to
complete this check list:

• [ ] If you added a new Config method, you wrote extensive documentation for
  it.

  <details>

  Our documentation should be of the following form:

  ```text
  Short, simple summary sentence.

  More details. These details can be multiple paragraphs. There should be
  information about not just the method, but its parameters and results as
  well.

  Is this method fallible? If so, when can it return an error?

  Can this method panic? If so, when does it panic?

  Example

  Optional example here.
  ```

  </details>

• [ ] If you added a new Config method, or modified an existing one, you
  ensured that this configuration is exercised by the fuzz targets.

  <details>

  For example, if you expose a new strategy for allocating the next instance
  slot inside the pooling allocator, you should ensure that at least one of our
  fuzz targets exercises that new strategy.

  Often, all that is required of you is to ensure that there is a knob for this
  configuration option in [wasmtime_fuzzing::Config][fuzzing-config] (or one
  of its nested structs).

  Rarely, this may require authoring a new fuzz target to specifically test this
  configuration. See [our docs on fuzzing][fuzzing-docs] for more details.

  </details>

• [ ] If you are enabling a configuration option by default, make sure that it
  has been fuzzed for at least two weeks before turning it on by default.

[fuzzing-config]: https://github.com/bytecodealliance/wasmtime/blob/ca0e8d0a1d8cefc0496dba2f77a670571d8fdcab/crates/fuzzing/src/generators.rs#L182-L194
[fuzzing-docs]: https://docs.wasmtime.dev/contributing-fuzzing.html

---

<details>

To modify this label's message, edit the <code>.github/label-messager/wasmtime-config.md</code> file.

To add new label messages or remove existing label messages, edit the
<code>.github/label-messager.json</code> configuration file.

Learn more.

</details>

Wasmtime GitHub notifications bot (Jun 28 2024 at 04:59):

pchickey submitted PR review.

Wasmtime GitHub notifications bot (Jul 08 2024 at 13:30):

alexcrichton merged PR #8882.

Last updated: Nov 22 2024 at 17:03 UTC