Wasmtime GitHub notifications bot (Jun 26 2024 at 19:02): Wasmtime GitHub notifications bot (Jun 26 2024 at 19:02):bjorn3 requested abrown for a review on PR #8875.
Wasmtime GitHub notifications bot (Jun 26 2024 at 19:02):bjorn3 requested wasmtime-compiler-reviewers for a review on PR #8875.
Wasmtime GitHub notifications bot (Jun 26 2024 at 19:02):bjorn3 opened PR #8875 from bjorn3:abi-cleanup to bytecodealliance:main:
I originally did these in the process of adding exception support to Cranelift, but I've extracted it out that branch and rebased it as these changes should be less controversial and it will help with rebasing the exception support branch in the future.
Wasmtime GitHub notifications bot (Jun 26 2024 at 19:05):bjorn3 updated PR #8875.
Wasmtime GitHub notifications bot (Jun 26 2024 at 19:07):bjorn3 updated PR #8875.
Wasmtime GitHub notifications bot (Jun 26 2024 at 19:11):bjorn3 updated PR #8875.
Wasmtime GitHub notifications bot (Jun 26 2024 at 20:02):bjorn3 updated PR #8875.
Wasmtime GitHub notifications bot (Jun 26 2024 at 21:44):github-actions[bot] commented on PR #8875:
Subscribe to Label Action
cc @cfallin, @fitzgen, @saulecabrera
<details>
This issue or pull request has been labeled: "cranelift", "cranelift:area:aarch64", "cranelift:area:machinst", "cranelift:area:x64", "isle", "winch"Thus the following users have been cc'd because of the following labels:
- cfallin: isle
- fitzgen: isle
- saulecabrera: winch
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (Jun 28 2024 at 01:09):abrown submitted PR review:
I read through this today and it all looks pretty reasonable. I feel like I need to review the safety bits, such as some of that register code, some more, though. Or maybe @jameysharpor @elliottt if you want to jump in?
Wasmtime GitHub notifications bot (Jun 28 2024 at 15:53):bjorn3 updated PR #8875.
Wasmtime GitHub notifications bot (Jun 28 2024 at 20:22):bjorn3 updated PR #8875.
Wasmtime GitHub notifications bot (Jun 29 2024 at 00:47):abrown submitted PR review:
I read through this today and it all looks pretty reasonable. I feel like I need to review the safety bits, such as some of that register code, some more, though. Or maybe @jameysharp or @elliottt if you want to jump in?
Wasmtime GitHub notifications bot (Jun 29 2024 at 02:36):jameysharp commented on PR #8875:
I'm excited to take a look next week if nobody else gets to this first!
Wasmtime GitHub notifications bot (Jun 29 2024 at 14:33):bjorn3 updated PR #8875.
Wasmtime GitHub notifications bot (Jul 03 2024 at 22:53):jameysharp commented on PR #8875:
I tried to review this and got kind of lost. I really appreciate that there are nicely separated commits, but I think this would be easier to review if those were fully separate PRs, if that's not too much trouble? It would be especially helpful if you can explain more about the motivation for each change in the commit/PR description.
Wasmtime GitHub notifications bot (Jul 05 2024 at 12:06):Split out https://github.com/bytecodealliance/wasmtime/pull/8903. I will rebase this PR once it merges.
Wasmtime GitHub notifications bot (Jul 05 2024 at 12:06):bjorn3 edited a comment on PR #8875:
Split out https://github.com/bytecodealliance/wasmtime/pull/8903 and added some motivation to the commit messages. I will rebase this PR once it merges.
Wasmtime GitHub notifications bot (Jul 05 2024 at 15:12):bjorn3 updated PR #8875.
Wasmtime GitHub notifications bot (Jul 16 2024 at 16:44):bjorn3 updated PR #8875.
Wasmtime GitHub notifications bot (Jul 16 2024 at 16:44):Rebased
Wasmtime GitHub notifications bot (Jul 16 2024 at 17:09):cfallin submitted PR review:
Looks reasonable, thanks! Just one nit below.
Wasmtime GitHub notifications bot (Jul 16 2024 at 17:09):cfallin submitted PR review:
Looks reasonable, thanks! Just one nit below.
Wasmtime GitHub notifications bot (Jul 16 2024 at 17:09):cfallin created PR review comment:
Could we define an enum for this (
IsTailCall::YesandIsTailCall::Nofor example) to make the callsites clearer?
Wasmtime GitHub notifications bot (Jul 16 2024 at 18:41):bjorn3 updated PR #8875.
Wasmtime GitHub notifications bot (Jul 16 2024 at 18:41):bjorn3 submitted PR review.
Wasmtime GitHub notifications bot (Jul 16 2024 at 18:41):bjorn3 created PR review comment:
Done
Wasmtime GitHub notifications bot (Jul 16 2024 at 20:21):cfallin merged PR #8875.
Last updated: Nov 22 2024 at 16:03 UTC