beetrees requested elliottt for a review on PR #8860.
beetrees requested wasmtime-compiler-reviewers for a review on PR #8860.
beetrees opened PR #8860 from beetrees:f16-f128-mvp
to bytecodealliance:main
:
Issue #8312
This PR adds initial basic support for
f16
andf128
to Cranelift. This is enough to allow the interpreter to bitcast to and fromf16
s andf128
s, as shown in the added filetest.
beetrees updated PR #8860.
jameysharp submitted PR review:
This looks great!
I didn't check the
Ieee16
/Ieee128
implementations super carefully and it would be nice to find ways to deduplicate the code for those fourIeee*
types a bit, but based on the tests I'm confident enough to merge these.I have a couple quick questions but overall I think this covers everything necessary to get started implementing these types. Thank you!
jameysharp submitted PR review:
This looks great!
I didn't check the
Ieee16
/Ieee128
implementations super carefully and it would be nice to find ways to deduplicate the code for those fourIeee*
types a bit, but based on the tests I'm confident enough to merge these.I have a couple quick questions but overall I think this covers everything necessary to get started implementing these types. Thank you!
jameysharp created PR review comment:
Perhaps this test should verify that
floats(16..64)
doubles tofloats(32..128)
.
jameysharp created PR review comment:
I don't remember exactly how we defined the bit-packed type IDs. Why is renumbering these lane types okay? Do we not use
4
/5
somewhere else?
jameysharp created PR review comment:
Maybe this should test that half-width of
floats(32..128)
isfloats(16..64)
? I'm not sure the separate32..32
case is necessary to test.
beetrees submitted PR review.
beetrees created PR review comment:
According to
constants.rs
,0x70-0x7d
are reserved for lane types (LANE_BASE
is0x70
), with the vector type bit-packing using 4 bits to identify the lane type. This means thatLANE_BASE + 0
toLANE_BASE + 13
inclusive are the possible valid lane types.
beetrees updated PR #8860.
beetrees created PR review comment:
Done as suggested
beetrees submitted PR review.
beetrees submitted PR review.
beetrees created PR review comment:
Done
beetrees updated PR #8860.
jameysharp commented on PR #8860:
Awesome, thank you!
jameysharp merged PR #8860.
Last updated: Dec 23 2024 at 12:05 UTC