Stream: git-wasmtime

Topic: wasmtime / PR #8859 Reduce the size of the wasp1 componen...

view this post on Zulip Wasmtime GitHub notifications bot (Jun 21 2024 at 16:33):

bjorn3 requested alexcrichton for a review on PR #8859.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 21 2024 at 16:33):

bjorn3 requested wasmtime-core-reviewers for a review on PR #8859.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 21 2024 at 16:33):

bjorn3 opened PR #8859 from bjorn3:smaller_wasip1_adapter_part2 to bytecodealliance:main:

This reduces the size of wasi_snapshot_preview1.command.wasm from 75029 bytes to 53875 bytes for a total win of 21154 bytes. This is done by deduplicating most of the trap messages and the code for printing those trap messages. Also got some small wins by making the assertion message shorter.

This is a continuation of https://github.com/bytecodealliance/wasmtime/pull/8858.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 21 2024 at 16:34):

bjorn3 commented on PR #8859:

For future reference: https://bytecodealliance.zulipchat.com/#narrow/stream/219900-wasi/topic/wasi-preview1-component-adapter.20size

view this post on Zulip Wasmtime GitHub notifications bot (Jun 21 2024 at 16:35):

bjorn3 updated PR #8859.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 21 2024 at 16:42):

bjorn3 updated PR #8859.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 21 2024 at 16:42):

bjorn3 edited PR #8859.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 21 2024 at 17:38):

alexcrichton submitted PR review:

These are some awesome wins, thanks for pushing on this!

view this post on Zulip Wasmtime GitHub notifications bot (Jun 21 2024 at 17:53):

alexcrichton merged PR #8859.

Last updated: Nov 22 2024 at 16:03 UTC