Wasmtime GitHub notifications bot (Jun 20 2024 at 15:22): Wasmtime GitHub notifications bot (Jun 20 2024 at 15:22):alexcrichton opened PR #8849 from alexcrichton:increase-pooling-allocator-defaults to bytecodealliance:main:
This commit raises the default setting of
max_memory_sizein the pooling allocator from 10M to 4G. This won't actually impact the virtual memory reserved in the pooling allocator because we already reserved 6G of virtual memory for each linear memory this instead allows access to all of it by default. This matches the default behavior of Wasmtime for the non-pooling allocator which is to not artificially limit memory by default.The main impact of this setting is that the memory-protection-keys feature, which is disabled by default, will have no effect by default unless
max_memory_sizeis also configured to something smaller than 4G. The documentation has been updated to this effect.Closes #8846
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Jun 20 2024 at 15:22):alexcrichton requested wasmtime-core-reviewers for a review on PR #8849.
Wasmtime GitHub notifications bot (Jun 20 2024 at 15:22):alexcrichton requested elliottt for a review on PR #8849.
Wasmtime GitHub notifications bot (Jun 20 2024 at 15:31):dicej submitted PR review.
Wasmtime GitHub notifications bot (Jun 20 2024 at 16:14):elliottt submitted PR review.
Wasmtime GitHub notifications bot (Jun 20 2024 at 16:35):alexcrichton merged PR #8849.
Last updated: Nov 22 2024 at 16:03 UTC