Wasmtime GitHub notifications bot (Jun 20 2024 at 00:00): Wasmtime GitHub notifications bot (Jun 20 2024 at 00:00):pchickey opened PR #8843 from bytecodealliance:pch/config_debug_all_wasm_features to bytecodealliance:main:
I noticed that the wasm_memory64 flag was left out of Config's debug impl, so rather than add it, I decided to use the
bitflags::Flags::FLAGSconst to iterate the complete set of flags.THe downside of this change is that it will print flags which do not have a setter in Config, e.g.
wasm_component_model_nested_names.An alternative to this change is, rather than expanding out the single
features: WasmFeaturesmember into many different debug_struct fields, the debug impl of WasmFeatures is used.Here is a sample debug of Config with this change:
Config { debug_info: None, wasm_mutable_global: true, wasm_saturating_float_to_int: true, wasm_sign_extension: true, wasm_reference_types: true, wasm_multi_value: true, wasm_bulk_memory: true, wasm_simd: true, wasm_relaxed_simd: false, wasm_threads: false, wasm_shared_everything_threads: false, wasm_tail_call: false, wasm_floats: true, wasm_multi_memory: false, wasm_exceptions: false, wasm_memory64: false, wasm_extended_const: false, wasm_component_model: false, wasm_function_references: false, wasm_memory_control: false, wasm_gc: false, wasm_custom_page_sizes: false, wasm_component_model_values: false, wasm_component_model_nested_names: false, parallel_compilation: true, compiler_config: CompilerConfig { strategy: Some(Cranelift), target: None, settings: {"opt_level": "speed", "enable_verifier": "true"}, flags: {}, cache_store: None, clif_dir: None, wmemcheck: false }, parse_wasm_debuginfo: false }<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Jun 20 2024 at 00:00):pchickey requested wasmtime-core-reviewers for a review on PR #8843.
Wasmtime GitHub notifications bot (Jun 20 2024 at 00:00):pchickey requested alexcrichton for a review on PR #8843.
Wasmtime GitHub notifications bot (Jun 20 2024 at 00:00):pchickey requested wasmtime-default-reviewers for a review on PR #8843.
Wasmtime GitHub notifications bot (Jun 20 2024 at 02:47):github-actions[bot] commented on PR #8843:
Label Messager: wasmtime:config
It looks like you are changing Wasmtime's configuration options. Make sure to
complete this check list:
[ ] If you added a new
Configmethod, you wrote extensive documentation for
it.<details>
Our documentation should be of the following form:
```text
Short, simple summary sentence.More details. These details can be multiple paragraphs. There should be
information about not just the method, but its parameters and results as
well.Is this method fallible? If so, when can it return an error?
Can this method panic? If so, when does it panic?
Example
Optional example here.
```</details>
[ ] If you added a new
Configmethod, or modified an existing one, you
ensured that this configuration is exercised by the fuzz targets.<details>
For example, if you expose a new strategy for allocating the next instance
slot inside the pooling allocator, you should ensure that at least one of our
fuzz targets exercises that new strategy.Often, all that is required of you is to ensure that there is a knob for this
configuration option in [wasmtime_fuzzing::Config][fuzzing-config] (or one
of its nestedstructs).Rarely, this may require authoring a new fuzz target to specifically test this
configuration. See [our docs on fuzzing][fuzzing-docs] for more details.</details>
[ ] If you are enabling a configuration option by default, make sure that it
has been fuzzed for at least two weeks before turning it on by default.[fuzzing-config]: https://github.com/bytecodealliance/wasmtime/blob/ca0e8d0a1d8cefc0496dba2f77a670571d8fdcab/crates/fuzzing/src/generators.rs#L182-L194
[fuzzing-docs]: https://docs.wasmtime.dev/contributing-fuzzing.html
<details>
To modify this label's message, edit the <code>.github/label-messager/wasmtime-config.md</code> file.
To add new label messages or remove existing label messages, edit the
<code>.github/label-messager.json</code> configuration file.</details>
Wasmtime GitHub notifications bot (Jun 20 2024 at 15:14):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Jun 20 2024 at 15:28):alexcrichton merged PR #8843.
Last updated: Oct 23 2024 at 20:03 UTC