Stream: git-wasmtime

Topic: wasmtime / PR #8843 wasmtime Config: debug impl now itera...


view this post on Zulip Wasmtime GitHub notifications bot (Jun 20 2024 at 00:00):

pchickey opened PR #8843 from bytecodealliance:pch/config_debug_all_wasm_features to bytecodealliance:main:

I noticed that the wasm_memory64 flag was left out of Config's debug impl, so rather than add it, I decided to use the bitflags::Flags::FLAGS const to iterate the complete set of flags.

THe downside of this change is that it will print flags which do not have a setter in Config, e.g. wasm_component_model_nested_names.

An alternative to this change is, rather than expanding out the single features: WasmFeatures member into many different debug_struct fields, the debug impl of WasmFeatures is used.

Here is a sample debug of Config with this change:

Config { debug_info: None, wasm_mutable_global: true, wasm_saturating_float_to_int: true, wasm_sign_extension: true, wasm_reference_types: true, wasm_multi_value: true, wasm_bulk_memory: true, wasm_simd: true, wasm_relaxed_simd: false, wasm_threads: false, wasm_shared_everything_threads: false, wasm_tail_call: false, wasm_floats: true, wasm_multi_memory: false, wasm_exceptions: false, wasm_memory64: false, wasm_extended_const: false, wasm_component_model: false, wasm_function_references: false, wasm_memory_control: false, wasm_gc: false, wasm_custom_page_sizes: false, wasm_component_model_values: false, wasm_component_model_nested_names: false, parallel_compilation: true, compiler_config: CompilerConfig { strategy: Some(Cranelift), target: None, settings: {"opt_level": "speed", "enable_verifier": "true"}, flags: {}, cache_store: None, clif_dir: None, wmemcheck: false }, parse_wasm_debuginfo: false }

<!--
Please make sure you include the following information:

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

view this post on Zulip Wasmtime GitHub notifications bot (Jun 20 2024 at 00:00):

pchickey requested wasmtime-core-reviewers for a review on PR #8843.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 20 2024 at 00:00):

pchickey requested alexcrichton for a review on PR #8843.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 20 2024 at 00:00):

pchickey requested wasmtime-default-reviewers for a review on PR #8843.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 20 2024 at 02:47):

github-actions[bot] commented on PR #8843:

Label Messager: wasmtime:config

It looks like you are changing Wasmtime's configuration options. Make sure to
complete this check list:

[fuzzing-config]: https://github.com/bytecodealliance/wasmtime/blob/ca0e8d0a1d8cefc0496dba2f77a670571d8fdcab/crates/fuzzing/src/generators.rs#L182-L194
[fuzzing-docs]: https://docs.wasmtime.dev/contributing-fuzzing.html


<details>

To modify this label's message, edit the <code>.github/label-messager/wasmtime-config.md</code> file.

To add new label messages or remove existing label messages, edit the
<code>.github/label-messager.json</code> configuration file.

Learn more.

</details>

view this post on Zulip Wasmtime GitHub notifications bot (Jun 20 2024 at 15:14):

alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 20 2024 at 15:28):

alexcrichton merged PR #8843.


Last updated: Dec 23 2024 at 12:05 UTC