Stream: git-wasmtime

Topic: wasmtime / PR #8842 Replace `simm32` extractor with `i32_...

Wasmtime GitHub notifications bot (Jun 19 2024 at 18:34):

alexcrichton opened PR #8842 from alexcrichton:better-simm32-matching to bytecodealliance:main:

This commit removes the simm32 extractor from lowerings as it's not as useful as it was when it was first introduced. Nowadays an Imm64 needs to be interpreted with the type known as well to understand whether bits being masked off is significant or not. The old simm32 extractor only took Imm64 meaning that it was unable to do this and wouldn't match negative numbers. This is because the high 32 bits of Imm64 were always zero and simm64 would take the i64 value from Imm64 and try to convert it to an i32.

This commit replaces simm32, and uses of it, with a new extractor i32_from_iconst. This matches the preexisting i64_from_iconst and is able to take the type of the value into account and produce a correctly sign-extended value.

cc #8706

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Jun 19 2024 at 18:34):

alexcrichton requested pchickey for a review on PR #8842.

Wasmtime GitHub notifications bot (Jun 19 2024 at 18:34):

alexcrichton requested abrown for a review on PR #8842.

Wasmtime GitHub notifications bot (Jun 19 2024 at 18:34):

alexcrichton requested wasmtime-core-reviewers for a review on PR #8842.

Wasmtime GitHub notifications bot (Jun 19 2024 at 18:34):

alexcrichton requested wasmtime-compiler-reviewers for a review on PR #8842.

Wasmtime GitHub notifications bot (Jun 19 2024 at 23:23):

abrown submitted PR review.

Wasmtime GitHub notifications bot (Jun 20 2024 at 15:26):

alexcrichton merged PR #8842.

Last updated: Oct 23 2024 at 20:03 UTC