Wasmtime GitHub notifications bot (Jun 19 2024 at 00:33): Wasmtime GitHub notifications bot (Jun 19 2024 at 00:33):pchickey requested alexcrichton for a review on PR #8838.
Wasmtime GitHub notifications bot (Jun 19 2024 at 00:33):pchickey requested cfallin for a review on PR #8838.
Wasmtime GitHub notifications bot (Jun 19 2024 at 00:33):pchickey opened PR #8838 from bytecodealliance:pch/wasm_tools_211 to bytecodealliance:main:
Only one change I wasn't certain of, for the
storage: &mut Stringparameter in wasmprinter:
https://github.com/bytecodealliance/wasmtime/compare/pch/wasm_tools_211?expand=1#diff-4863961fda2fef6610662e23fb35b7d7c2a367032798634425f2f407e0ee932aR70
Wasmtime GitHub notifications bot (Jun 19 2024 at 00:33):pchickey requested wasmtime-core-reviewers for a review on PR #8838.
Wasmtime GitHub notifications bot (Jun 19 2024 at 00:33):pchickey requested wasmtime-compiler-reviewers for a review on PR #8838.
Wasmtime GitHub notifications bot (Jun 19 2024 at 00:33):pchickey requested wasmtime-default-reviewers for a review on PR #8838.
Wasmtime GitHub notifications bot (Jun 19 2024 at 00:40):alexcrichton submitted PR review:
Minor things here and there but otherwise :+1:
Wasmtime GitHub notifications bot (Jun 19 2024 at 00:40):alexcrichton submitted PR review:
Minor things here and there but otherwise :+1:
Wasmtime GitHub notifications bot (Jun 19 2024 at 00:40):alexcrichton created PR review comment:
Mind matching
shared: falsehere and runningunimplemented!onshared: true?
Wasmtime GitHub notifications bot (Jun 19 2024 at 00:40):alexcrichton created PR review comment:
Looks good to me :+1:
Wasmtime GitHub notifications bot (Jun 19 2024 at 00:40):alexcrichton created PR review comment:
While you're here mind updating this to the
RefType::ANYREFshortcut?
Wasmtime GitHub notifications bot (Jun 19 2024 at 00:40):alexcrichton created PR review comment:
Mind matching
shared: falsehere explicitly and panicking/bailing onshared: true?
Wasmtime GitHub notifications bot (Jun 19 2024 at 00:40):alexcrichton created PR review comment:
(same for the changes below)
Wasmtime GitHub notifications bot (Jun 19 2024 at 02:17):pchickey updated PR #8838.
Wasmtime GitHub notifications bot (Jun 19 2024 at 02:18):pchickey has enabled auto merge for PR #8838.
Wasmtime GitHub notifications bot (Jun 19 2024 at 02:24):pchickey updated PR #8838.
Wasmtime GitHub notifications bot (Jun 19 2024 at 04:15):pchickey updated PR #8838.
Wasmtime GitHub notifications bot (Jun 19 2024 at 04:15):pchickey requested elliottt for a review on PR #8838.
Wasmtime GitHub notifications bot (Jun 19 2024 at 04:15):pchickey requested wasmtime-fuzz-reviewers for a review on PR #8838.
Wasmtime GitHub notifications bot (Jun 19 2024 at 06:44):github-actions[bot] commented on PR #8838:
Subscribe to Label Action
cc @fitzgen, @saulecabrera
<details>
This issue or pull request has been labeled: "cranelift", "cranelift:wasm", "fuzzing", "wasmtime:api", "winch"Thus the following users have been cc'd because of the following labels:
- fitzgen: fuzzing
- saulecabrera: winch
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (Jun 20 2024 at 01:09):alexcrichton updated PR #8838.
Wasmtime GitHub notifications bot (Jun 20 2024 at 01:55):alexcrichton commented on PR #8838:
Ok now that's something I wasn't expecting. Changing the crate dependency graph is changing
-Cmetadatato the adapter which is causing the symbols to change. For now that can be fixed by rebuilding the adapters locally but I'll try to work up a fix tomorrow to frob the name section to avoid the hashes being there.
Wasmtime GitHub notifications bot (Jun 20 2024 at 16:24):elliottt requested cfallin for a review on PR #8838.
Wasmtime GitHub notifications bot (Jun 20 2024 at 22:51):alexcrichton commented on PR #8838:
After poking at this a bit more I think we may want to instead revert the inclusion of binaries in-tree -- https://github.com/bytecodealliance/wasmtime/pull/8856 -- which if that lands then this would be unblocked.
Wasmtime GitHub notifications bot (Jun 21 2024 at 15:03):alexcrichton merged PR #8838.
Last updated: Nov 22 2024 at 17:03 UTC