Stream: git-wasmtime

Topic: wasmtime / PR #8830 Implement semver compatibility for ex...

Wasmtime GitHub notifications bot (Jun 18 2024 at 01:42):

alexcrichton requested elliottt for a review on PR #8830.

Wasmtime GitHub notifications bot (Jun 18 2024 at 01:42):

alexcrichton requested wasmtime-default-reviewers for a review on PR #8830.

Wasmtime GitHub notifications bot (Jun 18 2024 at 01:42):

alexcrichton requested wasmtime-core-reviewers for a review on PR #8830.

Wasmtime GitHub notifications bot (Jun 18 2024 at 01:42):

alexcrichton opened PR #8830 from alexcrichton:semver-compat-exports to bytecodealliance:main:

This commit is an implementation of component model semver compatibility for export lookups. Previously in #7994 component imports were made semver-aware to ensure that bumping version numbers would not be a breaking change. This commit implements the same feature for component exports. This required some refactoring to move the definition of semver compat around and the previous refactoring in #8786 enables frontloading this work to happen before instantiation.

Closes #8395

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Jun 18 2024 at 17:01):

elliottt submitted PR review:

Looks good to me! I had a few suggestions that you can take or leave :)

Wasmtime GitHub notifications bot (Jun 18 2024 at 17:01):

elliottt submitted PR review:

Looks good to me! I had a few suggestions that you can take or leave :)

Wasmtime GitHub notifications bot (Jun 18 2024 at 17:01):

elliottt created PR review comment:

    /// Inserts `s` into `self` and returns the intern'd key `Self::Key`.

Wasmtime GitHub notifications bot (Jun 18 2024 at 17:01):

elliottt created PR review comment:

Which usize entries? I think this is back when the comment referred to the Strings implementation details?

Wasmtime GitHub notifications bot (Jun 18 2024 at 17:01):

elliottt created PR review comment:

This was surprising to see, but I get that it's picking the () impl for NameMapIntern. What do you think about defining a special empty struct to write that impl for in names.rs instead? Something like NoInterning maybe?

Wasmtime GitHub notifications bot (Jun 18 2024 at 17:34):

alexcrichton updated PR #8830.

Wasmtime GitHub notifications bot (Jun 18 2024 at 17:34):

alexcrichton has enabled auto merge for PR #8830.

Wasmtime GitHub notifications bot (Jun 18 2024 at 17:59):

alexcrichton updated PR #8830.

Wasmtime GitHub notifications bot (Jun 18 2024 at 18:23):

alexcrichton merged PR #8830.

Last updated: Nov 22 2024 at 16:03 UTC