alexcrichton requested elliottt for a review on PR #8830.
alexcrichton requested wasmtime-default-reviewers for a review on PR #8830.
alexcrichton requested wasmtime-core-reviewers for a review on PR #8830.
alexcrichton opened PR #8830 from alexcrichton:semver-compat-exports
to bytecodealliance:main
:
This commit is an implementation of component model semver compatibility for export lookups. Previously in #7994 component imports were made semver-aware to ensure that bumping version numbers would not be a breaking change. This commit implements the same feature for component exports. This required some refactoring to move the definition of semver compat around and the previous refactoring in #8786 enables frontloading this work to happen before instantiation.
Closes #8395
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
elliottt submitted PR review:
Looks good to me! I had a few suggestions that you can take or leave :)
elliottt submitted PR review:
Looks good to me! I had a few suggestions that you can take or leave :)
elliottt created PR review comment:
/// Inserts `s` into `self` and returns the intern'd key `Self::Key`.
elliottt created PR review comment:
Which
usize
entries? I think this is back when the comment referred to theStrings
implementation details?
elliottt created PR review comment:
This was surprising to see, but I get that it's picking the
()
impl forNameMapIntern
. What do you think about defining a special empty struct to write thatimpl
for in names.rs instead? Something likeNoInterning
maybe?
alexcrichton updated PR #8830.
alexcrichton has enabled auto merge for PR #8830.
alexcrichton updated PR #8830.
alexcrichton merged PR #8830.
Last updated: Dec 23 2024 at 12:05 UTC