Stream: git-wasmtime

Topic: wasmtime / PR #8825 wasi-nn: use `libtest-mimic`

view this post on Zulip Wasmtime GitHub notifications bot (Jun 17 2024 at 20:19):

abrown opened PR #8825 from abrown:wasi-nn-libtest-mimic to bytecodealliance:main:

wasi-nn's testing story is complicated by different levels of support on different platforms (some backends work on certain architectures, others only work on certain OSes, etc.). This change migrates the testing module, which was included in src, to exist solely under tests. It also dynamically checks whether each test is runnable and then chooses whether to ignore it with a libtest-mimic flag. This ensures we can see all the tests all the time and whether they are running or not, which is helpful during development.

This adds a bit of complexity to wasi-nn testing but this is necessary for future improvements. In a future PR I will attempt to upgrade the WIT-ABI support for wasi-nn, which means testing some of these same test programs in their component form instead of core module form. This change lays that ground work.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 17 2024 at 20:19):

abrown requested alexcrichton for a review on PR #8825.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 17 2024 at 20:19):

abrown requested wasmtime-default-reviewers for a review on PR #8825.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 17 2024 at 20:19):

abrown requested wasmtime-core-reviewers for a review on PR #8825.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 17 2024 at 20:30):

alexcrichton submitted PR review:

Looks reasonable to me :+1:

view this post on Zulip Wasmtime GitHub notifications bot (Jun 17 2024 at 20:43):

abrown updated PR #8825.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 17 2024 at 21:27):

abrown updated PR #8825.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 17 2024 at 21:36):

abrown updated PR #8825.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 17 2024 at 21:53):

abrown updated PR #8825.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 17 2024 at 22:18):

abrown updated PR #8825.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 17 2024 at 22:25):

abrown has enabled auto merge for PR #8825.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 17 2024 at 22:45):

abrown merged PR #8825.

Last updated: Dec 23 2024 at 12:05 UTC