Stream: git-wasmtime

Topic: wasmtime / PR #8822 Force some more permission checks wit...

Wasmtime GitHub notifications bot (Jun 17 2024 at 18:39):

alexcrichton opened PR #8822 from alexcrichton:zero-length-writes to bytecodealliance:main:

When a 0-length write is performed try to send the write all the way to the underlying file descriptor to at least check that it's valid to write.

Closes #8818

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Jun 17 2024 at 18:39):

alexcrichton requested elliottt for a review on PR #8822.

Wasmtime GitHub notifications bot (Jun 17 2024 at 18:39):

alexcrichton requested wasmtime-core-reviewers for a review on PR #8822.

Wasmtime GitHub notifications bot (Jun 17 2024 at 18:56):

elliottt submitted PR review:

Looks good to me!

Wasmtime GitHub notifications bot (Jun 17 2024 at 18:56):

elliottt created PR review comment:

        .expect("opening a file for reading");

Wasmtime GitHub notifications bot (Jun 17 2024 at 18:56):

elliottt submitted PR review:

Looks good to me!

Wasmtime GitHub notifications bot (Jun 17 2024 at 18:57):

elliottt edited PR review comment.

Wasmtime GitHub notifications bot (Jun 17 2024 at 19:06):

alexcrichton updated PR #8822.

Wasmtime GitHub notifications bot (Jun 17 2024 at 19:06):

alexcrichton has enabled auto merge for PR #8822.

Wasmtime GitHub notifications bot (Jun 17 2024 at 19:41):

alexcrichton updated PR #8822.

Wasmtime GitHub notifications bot (Jun 17 2024 at 19:41):

alexcrichton commented on PR #8822:

Looks like the error differs on Windows and Linux. For now I've just updated the test to accept both errors.

Wasmtime GitHub notifications bot (Jun 17 2024 at 19:42):

alexcrichton has enabled auto merge for PR #8822.

Wasmtime GitHub notifications bot (Jun 17 2024 at 20:04):

alexcrichton merged PR #8822.

Last updated: Nov 22 2024 at 16:03 UTC