alexcrichton opened PR #8822 from alexcrichton:zero-length-writes
to bytecodealliance:main
:
When a 0-length write is performed try to send the write all the way to the underlying file descriptor to at least check that it's valid to write.
Closes #8818
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
alexcrichton requested elliottt for a review on PR #8822.
alexcrichton requested wasmtime-core-reviewers for a review on PR #8822.
elliottt submitted PR review:
Looks good to me!
elliottt created PR review comment:
.expect("opening a file for reading");
elliottt submitted PR review:
Looks good to me!
elliottt edited PR review comment.
alexcrichton updated PR #8822.
alexcrichton has enabled auto merge for PR #8822.
alexcrichton updated PR #8822.
alexcrichton commented on PR #8822:
Looks like the error differs on Windows and Linux. For now I've just updated the test to accept both errors.
alexcrichton has enabled auto merge for PR #8822.
alexcrichton merged PR #8822.
Last updated: Dec 23 2024 at 12:05 UTC