Stream: git-wasmtime

Topic: wasmtime / PR #8813 Disable memory protection keys by def...


view this post on Zulip Wasmtime GitHub notifications bot (Jun 14 2024 at 21:34):

alexcrichton opened PR #8813 from alexcrichton:disable-memory-protection-keys to bytecodealliance:main:

This commit gates memory protection keys behind a new Cargo feature which is disabled by default. Memory protection keys are already disabled by default on all platforms and are only configured to possibly work with Linux x64. When enabled, however, it unconditionally adds a small amount of overhead to WebAssembly entries/exits even if the feature is disabled at runtime for the same reason that the call-hook feature adds overhead. With call-hook being disabled by default in #8808 it seemed reasonable to additionally gate memory protection keys to avoid needing to disable features in Wasmtime to get the best performance wasm<->host calls.

<!--
Please make sure you include the following information:

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

view this post on Zulip Wasmtime GitHub notifications bot (Jun 14 2024 at 21:34):

alexcrichton requested pchickey for a review on PR #8813.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 14 2024 at 21:34):

alexcrichton requested wasmtime-core-reviewers for a review on PR #8813.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 14 2024 at 21:34):

alexcrichton requested wasmtime-default-reviewers for a review on PR #8813.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 14 2024 at 21:34):

alexcrichton commented on PR #8813:

cc @abrown to give you a heads up

view this post on Zulip Wasmtime GitHub notifications bot (Jun 14 2024 at 21:43):

alexcrichton updated PR #8813.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 14 2024 at 21:43):

alexcrichton requested wasmtime-fuzz-reviewers for a review on PR #8813.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 14 2024 at 21:43):

alexcrichton requested fitzgen for a review on PR #8813.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 14 2024 at 21:49):

fitzgen submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 14 2024 at 21:54):

abrown submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 14 2024 at 23:23):

alexcrichton merged PR #8813.


Last updated: Dec 23 2024 at 12:05 UTC